Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add reth configuration & cleanup configs #271

Merged
merged 8 commits into from
Jun 14, 2024

Conversation

danyalprout
Copy link
Collaborator

@danyalprout danyalprout commented Jun 12, 2024

Description

  • Add reth client build
    • Build reth image on PRs
    • Publish a reth image on merge to main & tags (couldn't test this -- so may require one or two iterations).
  • Remove the genesis/rollup config files as these are now baked into the binaries
  • Renamed the base-org/node image to base-org/node-geth but continue to publish geth builds to both

TODO

  • Add optimizations for op-reth
  • Confirm the Github Actions CI works on main (will require a merge)
  • Set op-reth to a tag (waiting for it to be published)

@danyalprout danyalprout changed the title chore: add reth configuration & cleanup chore: add reth configuration & cleanup configs Jun 12, 2024
@danyalprout danyalprout marked this pull request as ready for review June 12, 2024 21:30
.github/workflows/docker.yml Show resolved Hide resolved
Dockerfile.reth Outdated
RUN apt-get update && apt-get -y upgrade && apt-get install -y git libclang-dev pkg-config curl build-essential

ENV REPO=https://github.com/paradigmxyz/reth.git
ENV COMMIT=1c148e7f030f0b6b3610564e0142c799756666f4
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this doesn't appear to be in a version. Once reth cuts a release I'll update this to match how we clone op-node.

Dockerfile.reth Outdated Show resolved Hide resolved
Dockerfile.reth Outdated Show resolved Hide resolved
Copy link

@BrianBland BrianBland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the removal of the mainnet and sepolia directories, it may make more sense to split these files into reth and geth directories. That being said, this is good enough for a first pass.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jun 13, 2024

🟡 Heimdall Review Status

Item Status More Info
Minimum Required Reviews 🟡 0/1
Show calculation
Show calculations
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculations
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

📝 Heimdall docs · 🕵️ Advanced details · ♻️ Refresh Heimdall · #️⃣ #ask-heimdall

.env Outdated Show resolved Hide resolved
@danyalprout danyalprout merged commit acc4e30 into base-org:main Jun 14, 2024
6 checks passed
@danyalprout danyalprout deleted the reth branch June 14, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants