Update Fault Proof contract addresses for Sepolia #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Post-Granite, new implementation contracts were deployed,
but their new addresses were not reflected in the docs.
It is quite simple to independently verify.
The `DisputeGameFactoryProxy` should not have changed.
Staring with the game implementations, simply call the
read method, `gameImpls(uint32)`, to get the implementation
for game type 0 (`FaultDisputeGame`), and 1 (`PermissionedDisputeGame`).
From those addresses, you can then call the game implementations
to get the `MIPS` / VM (`vm()`), and `DelayedWETHProxy` (`weth()`)
addresses.
Sample command:
cast call --rpc-url <ETH Sepolia RPC URL> 0xd6E6dBf4F7EA0ac412fD8b65ED297e64BB7a06E1 "gameImpls(uint32)" 0
The `AnchorStateRegistryProxy` should remain unchanged as well.
✅ Heimdall Review Status
|
|
@cbfyi is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
awilliams1-cb
suggested changes
Oct 28, 2024
|
Review Error for awilliams1-cb @ 2024-10-28 19:43:48 UTC |
Co-authored-by: Alexis Williams <148368153+awilliams1-cb@users.noreply.github.com>
awilliams1-cb
approved these changes
Oct 28, 2024
|
Review Error for awilliams1-cb @ 2024-10-28 22:04:03 UTC |
|
+1 @wbnns ? 🙏 |
wbnns
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Post-Granite, new implementation contracts were deployed, but their new addresses were not reflected in the docs.
Notes to reviewers
Related to https://github.com/ethereum-optimism/superchain-ops/tree/main/tasks/sep/base-004-fp-audit-fixes and base-org/contract-deployments#214
How has it been tested?
It is quite simple to independently verify.
The
DisputeGameFactoryProxyshould not have changed.Staring with the game implementations, simply call the read method,
gameImpls(uint32), to get the implementation for game type 0 (FaultDisputeGame), and 1 (PermissionedDisputeGame).From those addresses, you can then call the game implementations to get the
MIPS/ VM (vm()), andDelayedWETHProxy(weth()) addresses.Sample command:
The
AnchorStateRegistryProxyshould remain unchanged as well.