Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for irb 1.13+ #114

Merged
merged 2 commits into from
May 22, 2024
Merged

Support for irb 1.13+ #114

merged 2 commits into from
May 22, 2024

Conversation

valeronm
Copy link
Contributor

irb in version 1.13 started to call @context.evaluate with IRB::Statement argument instead of String (PR: ruby/irb#920) and so we need to support both ways of calling evaluate

Fixes #110

Copy link
Member

@rosa rosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, nice catch! 💯 🙇‍♀️ Thank you!

@rosa rosa merged commit fe7f9a5 into basecamp:master May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

irb 1.13.1 only logging IRB::Statement::Expression rather than actual lines
2 participants