Merge pull request #967 from basecamp/fix-attribute-check

Fix ensureAttachmentExclusivelyHasAttribute
basecamp · Apr 6, 2022 · 72c7404 · 72c7404
2 parents 650d481 + 406b522
commit 72c7404
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/trix/core/collections/hash.js b/src/trix/core/collections/hash.js
@@ -49,7 +49,7 @@ export default class Hash extends TrixObject {
   slice(keys) {
     const values = {}
 
-    keys.forEach((key) => {
+    Array.from(keys).forEach((key) => {
       if (this.has(key)) {
         values[key] = this.values[key]
       }

diff --git a/src/trix/models/attachment_piece.js b/src/trix/models/attachment_piece.js
@@ -23,7 +23,7 @@ export default class AttachmentPiece extends Piece {
   ensureAttachmentExclusivelyHasAttribute(attribute) {
     if (this.hasAttribute(attribute)) {
       if (!this.attachment.hasAttribute(attribute)) {
-        this.attachment.setAttributes(this.attributes.slice(attribute))
+        this.attachment.setAttributes(this.attributes.slice([ attribute ]))
       }
       this.attributes = this.attributes.remove(attribute)
     }