Ignore multiple start() calls
#1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes duplicate `Trix.start()` calls harmless, so that clients don't need to keep track of whether they have previously called it. Previously calling `start()` a second time raised an error. This makes it easier for clients that delay importing Trix until it's needed, and may have `Trix.start()` calls in multiple places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes duplicate
Trix.start()calls harmless, so that clients don't need to keep track of whether they have previously called it. Previously callingstart()a second time raised an error.This makes it easier for clients that delay importing Trix until it's needed, and may have
Trix.start()calls in multiple places.