fix(attachment): allow captions to be deleted #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This worked in v1.3.5 but it was removed in basecamp@7f742dc#diff-e002f6f45c988abee91b7486a2bf15b07762e0d230d3d279847a7098cd7ab5abL69-R68 which I believe was a mistake: `""` is an empty caption that in v1.3.5 would restore the default caption (`""` is not loosely equal to `null`) but since v2 it does nothing (`""` is falsy).
|
Thanks @Thomaash 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This worked in v1.3.5 but it was removed in 7f742dc#diff-e002f6f45c988abee91b7486a2bf15b07762e0d230d3d279847a7098cd7ab5abL69-R68 which I believe was a mistake:
""is an empty caption that in v1.3.5 would restore the default caption (""is not loosely equal tonull) but since v2 it does nothing (""is falsy).