Restore detection of text direction on Chrome #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afcapel
force-pushed
the
chrome-rtl-support
branch
from
8daafe8 to
50cf4d3
Compare
afcapel
force-pushed
the
chrome-rtl-support
branch
from
50cf4d3 to
a85487f
Compare
afcapel
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome recently changed (or broke) the
dirnamesupport forinput, and it doesn't set the direction on the containing form. This results in the RTL text to align left.This PR adds a
textareato restore the behaviour on Chrome. We still need theinputto support the:dir(rtl|ltr)pseudo-class query for Firefox.Fixes #1059