Fix caret move on iOS 17 #1090
Merged
Fix caret move on iOS 17 #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an issue with iOS 17 where if you move the caret and then press backwards, for example because you made a typo, the caret will jump to its previous position. This is because on the onselectionchange event the event handler doesn't see the caret move as a new DOM range. It thinks the DOM range is the same as before and doesn't notify the registered observers. If we receive an onselectionchange event and the selection type is "Caret" that means the caret moved and we should notify the observers, regardless of whether the DOM range is the same as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue with iOS 17 where if you move the caret and then press backwards, for example because you made a typo, the caret will jump to its previous position. This is because on the onselectionchange event the event handler doesn't see the caret move as a new DOM range. It thinks the DOM range is the same as before and doesn't notify the registered observers.
If we receive an onselectionchange event and the selection type is "Caret" that means the caret moved and we should notify the observers, regardless of whether the DOM range is the same as before.