Add default word-break to trix-content #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzimdars
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Looks good to me. In our apps we've been compensating for this in local CSS. Makes sene to upstream it.
For example: https://github.com/basecamp/haystack/blob/master/app/assets/stylesheets/web/components/trix.scss#L203
|
Actually, this bug still remains. |
|
@huabin are you sure you're using the latest version css? Seems ok in trix-editor.org 
|
|
Hey @afcapel, I tried on https://trix-editor.org on Firefox, it happened, that's why I leave my reply. I have tried on Firefox, Chrome and Safari just now, it works well on them. BTW, I reinstalled Firefox, maybe this issue was caused by the Firefox I was using at the time. :( |
|
No worries, glad it's fixed now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1125