Read the csp meta tag nonce attribute and fall back to content #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll release a new version shortly including this one. |
seanpdoyle
added a commit
to seanpdoyle/trix
that referenced
this pull request
Nov 20, 2024
Follow-up to [basecamp#1151][]. Add unit test coverage for the `installDefaultCSSForTagName` functions support for both `meta[content]` and `meta[nonce]` attribute support. [basecamp#1151]: basecamp#1151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows Trix to support rails/rails#51729. This changes Trix to read the meta tag's nonce attribute first and fall back to the content attribute.
As described in rails/rails#51580 (comment) this makes it harder to extract the nonce value.
Similar to hotwired/turbo#1254