Fix bug with dictation on iOS 18+ #1191
Conversation
karma.conf.js
Outdated
| base: "SauceLabs", | ||
| browserName: "safari", | ||
| platform: "macOS 10.13", | ||
| version: "12.1" | ||
| version: "16.4" |
There was a problem hiding this comment.
@seanpdoyle I got a CI error due to attachInternals failing in old Safari. I wondered why it passed the other day in your PR. It seems it didn't run the sauce tests there?
There was a problem hiding this comment.
That's surprising.
The merge commit failed against main, but passed (or did not run) on the PR.
There was a problem hiding this comment.
CI reads the SAUCE-prefixed environment variables from GitHub action secrets, sets them as environment variables, then reads those values as part of the Karma setup.
However,
With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.
That means unless there is an alternative solution, pull requests from the community won't run in Sauce Labs managed environments. That seems like a risk to the project's backwards compatibility goals.
jorgemanrubia
force-pushed
the
ios-dictation-bug
branch
5 times, most recently
from
21f6c67
to
0346be1
Compare
jorgemanrubia
force-pushed
the
ios-dictation-bug
branch
from
654adcb
to
073e532
Compare
Dictation on iOS does not trigger composition events (https://bugs.webkit.org/show_bug.cgi?id=261764). Instead, it triggers `beforeinput` events with `insertText`. During the dictation phase, it keeps the range anchored to the cursor, and iOS may modify past text as new text adds context. Once dictation is stopped, it starts sending `insertText` events with word fragments. When a past fragment is altered, iOS sends a `beforeinput` event where `inputType` is null. In this case, perform a synchronous render operation to set the editor to the correct state. Otherwise, scheduled render requests can process invalid ranges and mess with the editor contents.
jorgemanrubia
force-pushed
the
ios-dictation-bug
branch
from
073e532
to
776e1ce
Compare
Fixes a bug where dictating in iOS 18 can result in losing or garbling existing content.
Dictation on iOS does not trigger composition events (https://bugs.webkit.org/show_bug.cgi?id=261764). Instead, it triggers
beforeinputevents withinsertText. During the dictation phase, it keeps the range anchored to the cursor, and iOS may modify past text as new text adds context.Once dictation is stopped, it starts sending
insertTextevents with word fragments. When a past fragment is altered, iOS sends abeforeinputevent whereinputTypeis null. In this case, the patch makes Trix perform a synchronous render operation to set the editor to the correct state. Otherwise, scheduled render requests can process invalid ranges and mess with the editor contents.