Idempotent Custom Element registration #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the package is accidentally imported a second time, the Custom Element registrations will raise an exception like: ``` NotSupportedError: Cannot define multiple custom elements with the same tag name ``` This commit adds a guard that checks whether or not the element has been registered through a call to [CustomElementRegistry.get][]. When present, the redundant call to [CustomElementRegistry.define][] is skipped. [CustomElementRegistry.get]: https://developer.mozilla.org/en-US/docs/Web/API/CustomElementRegistry/get [CustomElementRegistry.define]: https://developer.mozilla.org/en-US/docs/Web/API/CustomElementRegistry/define
|
Thanks @seanpdoyle 🙏 FYI V2 has a similar check although slightly different implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the package is accidentally imported a second time, the Custom
Element registrations will raise an exception like:
This commit adds a guard that checks whether or not the element has been
registered through a call to CustomElementRegistry.get. When
present, the redundant call to CustomElementRegistry.define is
skipped.