Replace callbacks with async/await in tests #994
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids deep nesting, especially when some async events, like inputs in tests, are performed in sequence.
The nesting was never very readable, but since we moved away from coffeescript it became even messier with the added closing curly brackets.
Note that I've replaced most calls to
defer(callback)
withawait nextFrame()
. However,defer
is implemented as a 1ms delay whilenextFrame
is just callingrequestAnimationFrame
. They should be roughly equivalent but there might be slight differences that can make the some tests flaky. I suggest patching those tests adjusting the delay if we see they are flaky.