Extract partials and add ids we'll need for the stream actions approach

basecamp · Nov 26, 2023 · 944ad5d · 944ad5d
1 parent 90840b3
commit 944ad5d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/app/helpers/projects_helper.rb b/app/helpers/projects_helper.rb
@@ -1,5 +1,6 @@
 module ProjectsHelper
   def project_progress_bar_for(project)
-    tag.progress "#{project.completion_ratio * 100}%", value: project.tasks.completed.count, max: project.tasks.count, class: "progress is-primary"
+    tag.progress "#{project.completion_ratio * 100}%", id: dom_id(project, :progress_bar),
+      value: project.tasks.completed.count, max: project.tasks.count, class: "progress is-primary"
   end
 end
diff --git a/app/views/projects/_complete_count.html.erb b/app/views/projects/_complete_count.html.erb
@@ -0,0 +1 @@
+<span id="<%= dom_id(project, :complete_count) %>" class="tag is-info"><%= project.tasks.completed.count %> / <%= project.tasks.count %> </span>
diff --git a/app/views/projects/_tasks.html.erb b/app/views/projects/_tasks.html.erb
@@ -1,5 +1,4 @@
-
-<table class="table is-fullwidth is-stripped">
+<table id="tasks" class="table is-fullwidth is-stripped">
   <thead>
   <tr>
     <th style="width: 4rem;"></th>
@@ -13,8 +12,7 @@
   <tfoot>
   <tr>
     <th>
-      <span class="tag is-info"><%= tasks.completed.count %>
-        / <%= tasks.count %> </span>
+      <%= render "projects/complete_count", project: project %>
     </th>
     <th>
     </th>
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		<span id="<%= dom_id(project, :complete_count) %>" class="tag is-info"><%= project.tasks.completed.count %> / <%= project.tasks.count %> </span>