fix unittest

Signed-off-by: zwwhdls <zww@hdls.me>
basenana · Dec 17, 2024 · e397d12 · e397d12
1 parent a50279f
commit e397d12
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 26 deletions.
diff --git a/pkg/store/meili/mock.go b/pkg/store/meili/mock.go
@@ -113,39 +113,31 @@ func (m *MockClient) FilterDocuments(ctx context.Context, filter *doc.DocumentFi
 				all := len(aq.AttrQueries)
 				matched := true
 				for _, q := range aq.AttrQueries {
-					if q.Attr == "entryId" {
+					switch q.Attr {
+					case "entryId":
 						all -= 1
 						if !match(q, attr.EntryId) {
 							matched = false
-							continue
 						}
-					}
-					if q.Attr == "namespace" {
+					case "namespace":
 						all -= 1
 						if !match(q, attr.Namespace) {
 							matched = false
-							continue
 						}
-					}
-					if q.Attr == "key" {
+					case "key":
 						all -= 1
 						if !match(q, attr.Key) {
 							matched = false
-							continue
 						}
-					}
-					if q.Attr == "value" {
+					case "value":
 						all -= 1
 						if !match(q, attr.Value) {
 							matched = false
-							continue
 						}
-					}
-					if q.Attr == "kind" {
+					case "kind":
 						all -= 1
 						if !match(q, attr.Kind) {
 							matched = false
-							continue
 						}
 					}
 				}
@@ -160,6 +152,8 @@ func (m *MockClient) FilterDocuments(ctx context.Context, filter *doc.DocumentFi
 				Option: "IN",
 				Value:  entryId,
 			})
+		} else {
+			return nil, nil
 		}
 	}
 
@@ -168,32 +162,26 @@ func (m *MockClient) FilterDocuments(ctx context.Context, filter *doc.DocumentFi
 		matched := true
 		all := len(query.AttrQueries)
 		for _, q := range query.AttrQueries {
-			if q.Attr == "entryId" {
+			switch q.Attr {
+			case "entryId":
 				all -= 1
 				if !match(q, d.EntryId) {
 					matched = false
-					continue
 				}
-			}
-			if q.Attr == "namespace" {
+			case "namespace":
 				all -= 1
 				if !match(q, d.Namespace) {
 					matched = false
-					continue
 				}
-			}
-			if q.Attr == "id" {
+			case "id":
 				all -= 1
 				if !match(q, d.Id) {
 					matched = false
-					continue
 				}
-			}
-			if q.Attr == "kind" {
+			case "kind":
 				all -= 1
 				if !match(q, d.Kind) {
 					matched = false
-					continue
 				}
 			}
 		}

diff --git a/pkg/store/meili/model.go b/pkg/store/meili/model.go
@@ -197,7 +197,7 @@ func (d *DocumentAttrList) FromModel(doc *doc.Document) *DocumentAttrList {
 			Namespace: doc.Namespace,
 			EntryId:   fmt.Sprintf("%d", doc.EntryId),
 			Key:       "parentId",
-			Value:     fmt.Sprintf("%d", *doc.ParentEntryID),
+			Value:     *doc.ParentEntryID,
 		})
 	}
 	mark := false