fix #3120 カスタムコンテンツを２つ以上トップページなどで一覧表示させるとアイキャッチが取得できない問題を解決 #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryuring
reviewed
Feb 15, 2024
| @@ -214,7 +214,7 @@ public function getFieldValue(mixed $entry, string $fieldName, array $options = | |||
|
|
|||
| $customLink = $this->getLink($entry->custom_table_id, $fieldName); | |||
|
|
|||
| if (!$customLink->display_front) return ''; | |||
| if (empty($customLink->display_front) || !$customLink->display_front) return ''; | |||
There was a problem hiding this comment.
@katokaisya 念のためレビューいれます。
empty() を使うのであれば、|| !$customLink->display_front は不要です。
There was a problem hiding this comment.
if (empty($customLink) || !$customLink->display_front) return ''; こちらだったらまだわかりますが
|
@katokaisya ちなみに、こちらのコミットで、アイキャッチが取得できないという根本原因は解決できるのでしょうか？ |
|
@ryuring
こちら、根本解決にはなっていなかったです。 |
|
@katokaisya 了解です、マージします |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ryuring
シンプルにWarning対策を行っています。
お手数ですが、ご確認の上、マージをお願いします。
Warning (2) : Attempt to read property "display_front" on bool [in /var/www/html/vendor/baserproject/bc-custom-content/src/View/Helper/CustomContentHelper.php, line 217]