Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ##4099 5.0.x系にて、カスタムコンテンツ一覧表示件数が管理画面通りにならない問題を解決 #4100

Open
wants to merge 1 commit into
base: 5.0.x
Choose a base branch
from

Conversation

katokaisya
Copy link
Collaborator

@ryuring

本来であれば

        $this->set($service->getViewVarsForIndex(
            $customContent,
            $this->paginate(
                $service->getCustomEntries($customContent, $this->getRequest()->getQueryParams()),
                ['limit' => $customContent->list_count,
                    'sort' => $customContent->list_order,
                    'direction' => $customContent->list_direction
                ]
            )
        ));

のほうが望ましいのですが、一旦5.1.xと同様に

        $this->set($service->getViewVarsForIndex(
            $customContent,
            $this->paginate(
                $service->getCustomEntries($customContent, $this->getRequest()->getQueryParams()),
                ['limit' => $customContent->list_count]
            )
        ));

としています。
お手数ですが、ご確認の上、5.0.xへとマージお願いします。

@ryuring
Copy link
Collaborator

ryuring commented Dec 29, 2024

@katokaisya ユニットテストが失敗していますので一度確認お願いします。

@ryuring ryuring assigned katokaisya and unassigned ryuring Dec 29, 2024
@ryuring ryuring added the Reviewed レビュー済 label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed レビュー済
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants