Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-deterministic test needs a little ?SOMETIMES #13

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Conversation

russelldb
Copy link
Member

prop_quantile/0 is by it's nature non-deterministic, and the
comments/notes make it clear. Rather than tolerate it breaking the build
periodically, this commit changes the property by using eqc's
?SOMETIMES macro. If a test fails 3 times in a row then we assume that
it is a deterministic failure, a bug. Otherwise, assume it is the noted
"loosy goosy" nature of the comparison and pass the property. NOTE:
still think we should find and fit the error bounds.

prop_quantile/0 is by it's nature non-deterministic, and the
comments/notes make it clear. Rather than tolerate it breaking the build
periodically, this commit changes the property by using eqc's
`?SOMETIMES` macro. If a test fails 3 times in a row then we assume that
it is a deterministic failure, a bug. Otherwise, assume it is the noted
"loosy goosy" nature of the comparison and pass the property. NOTE:
still think we should find and fit the error bounds.
@martincox
Copy link

+1. +10 for loosy goosy 😄

@russelldb russelldb merged commit 2ebff3f into master Feb 20, 2018
@russelldb russelldb deleted the develop-2.2.5 branch February 20, 2018 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants