add fns and test to get active preflist w/ partition nums, annotated, by... #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove use of `@title` tag in module. From the [Edoc User's Guide 0.7.13](http://www.erlang.org/doc/apps/edoc/chapter.html): Specifies a title for the overview page. This tag can _only_ be used in an overview file. The content can be arbitrary text.
Edoc complains and fails to build the file. Unfortunately, putting the comment below or above the `-callback` doesn't get it to show up in the html. But this at least allows it to succeed.
EDoc doesn't seem to like the `{@see foo/1}` syntax within a larger `@doc`.
I've only gotten `@see` to work as the first bit of a comment line:
```erlang
%% @doc foo bar baz
%% @see foo/1
```
Many of the inline uses I was able to simply change to use `{@link
foo/2}`.
Edoc now successfully completes with no errors or warnings.
Edoc cleanup Reviewed-by: andrewjstone
Add handoff.ip to core cuttlefish schema Reviewed-by: andrewjstone
This was referenced Jan 28, 2015
Conflicts: rebar.config
Merge 2.0 into develop. Reviewed-by: seancribbs
…e-active-preflist-on-bucket-key
|
Opening a PR against develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... bucket-key
Returns active preflist as
[{{34, 'dev5@127.0.0.1'}, primary}, {{35, 'dev6@127.0.0.1'}, primary}, ...]Description
Part of RIAK-1481.
The active preflist will return primary/fallback partitions and nodes for the available nodes at the time of query. Primary/fallback will be annotated.
This involves updates to our RiakKV WB code, RiakPB, RiakCore, and RiakAPI.
*The impetus for adding this to the API started with a mailing list question answered by Charlie Voiselle, http://lists.basho.com/pipermail/riak-users_lists.basho.com/2015-January/016527.html, which involved a snippet of code that we've given clients multiple times. This was then discussed with Russell Brown on HipChat, https://basho.hipchat.com/history/room/867200/2015/01/13?q=enterprising&t=rid-867200#12:23:22.
Other PRs in the series: