Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request keys and hashes off loop #818

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Request keys and hashes off loop #818

merged 1 commit into from
Dec 16, 2022

Conversation

martinsumner
Copy link
Contributor

See #817

Look to resolve deadlock by handling request in sender loop rather than blocking riak_repl_aae_sink waiting for this result.

@martinsumner
Requests keys and hashes off loop
33dbc30 
See #817

Look to resolve deadlock by handling request in sender loop rather than blocking riak_repl_aae_sink waiting for this result.
@martinsumner
Copy link
Contributor Author

Passes all repl_all riak_test tests. However, these tests verify full-sync only at low volumes.

@martinsumner martinsumner changed the title Requests keys and hashes off loop Request keys and hashes off loop Dec 12, 2022
@azharnisar
Copy link

+1

@martinsumner
Copy link
Contributor Author

#817 (comment)

@martinsumner martinsumner merged commit bbbf3c4 into develop-3.0 Dec 16, 2022
@martinsumner martinsumner deleted the mas-i817-segments branch December 16, 2022 16:05
martinsumner added a commit that referenced this pull request Dec 19, 2022
@martinsumner
Requests keys and hashes off loop (#818)
bf74f36 
See #817

Look to resolve deadlock by handling request in sender loop rather than blocking riak_repl_aae_sink waiting for this result.
martinsumner added a commit that referenced this pull request Dec 19, 2022
@martinsumner
Develop d30updated (#819)
84be09f 
* Requests keys and hashes off loop (#818)

See #817

Look to resolve deadlock by handling request in sender loop rather than blocking riak_repl_aae_sink waiting for this result.

* Tidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinsumner @azharnisar