Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for riak_repl#774 #1301

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Add a test for riak_repl#774 #1301

merged 1 commit into from
Oct 21, 2019

Conversation

russelldb
Copy link
Member

See issue basho/riak_repl#774 for details.

Tests basho/riak_repl#777

@russelldb
Add a test for riak_repl#774
759ceb1 
See issue for details.
@bryanhuntesl
Copy link

Tests pass if I first apply this patch to develop-2.2.5 - then merge your branch.

fix_riak_test.patch.txt

bryanhuntesl
bryanhuntesl approved these changes Mar 26, 2018
View reviewed changes
Copy link

@bryanhuntesl bryanhuntesl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This P/R looks good with either of our p/r ( #1303 / #1304 ) merged before. +1 after merging one of the prerequisite p/r

@martinsumner
Copy link

Added to develop-2.9 and develop-3.0. OK to merge to develop-2.2.5 for completeness.

@martinsumner martinsumner merged commit ac497d8 into develop-2.2.5 Oct 21, 2019
@martinsumner martinsumner deleted the bug/rdb/nhs-riak-repl-gh-774 branch October 21, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanhuntesl bryanhuntesl bryanhuntesl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russelldb @bryanhuntesl @martinsumner