Better support for wildcard certificates: #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JeetKunDoug
commented
Feb 11, 2015
JeetKunDoug
commented
- Update make_certs to support wildcard certificates by passing an additional Path parameter.
- add replication2_ssl test to ensure using wildcard certificates works after PR to riak_core_ssl_util.
- Update make_certs to support wildcard certificates by passing an additional Path parameter. - add replication2_ssl test to ensure using wildcard certificates works after PR to riak_core_ssl_util.
|
Depends on basho/riak_core#701, which is being held until 2.0.5 is released, so please DON'T MERGE yet. |
| @@ -112,8 +112,14 @@ intermediateCA(Root, CA, ParentCA) -> | |||
| endusers(Root, CA, Users) -> | |||
| [enduser(Root, CA, User) || User <- Users]. | |||
|
|
|||
| enduser(Root, CA, User) -> | |||
| UsrRoot = filename:join([Root, User]), | |||
| enduser(Root, CA, {User, Path}) -> | |||
There was a problem hiding this comment.
Minor, but I'd prefer if the Path parameter was named something like DirName, as it's only one segment of the filesystem path.
- Change Path -> DirName in make_certs - Added both more basic and more advanced tests with wildcard certs
JeetKunDoug
force-pushed
the
feature/support_wildcard_certs_in_tests
branch
from
1f7ae6c
to
137a11c
Compare
|
+1 137a11c |
JeetKunDoug
added a commit
that referenced
this pull request
Feb 25, 2015
…tests Better support for wildcard certificates - riak_core#701 is now merged, so merging tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.