Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add macos arm64 build #12

Merged

Conversation

faroit
Copy link
Contributor

@faroit faroit commented May 17, 2022

  • add dylib built locally
  • remove --enable-werror from script

@bastibe
Copy link
Owner

bastibe commented May 17, 2022

Brilliant! Thank you so much!

@bastibe bastibe merged commit 1e2c501 into bastibe:bastibe/1.1.0-build May 17, 2022
@bastibe
Copy link
Owner

bastibe commented May 20, 2022

A user in bastibe/python-soundfile#325 just reported that the M1 binary you provided seems to lack MP3 support. Did you compile it from the version of mac_build.sh from the 1.1.0 branch?

And might I ask once more for your help compiling an M1 binary for 1.1.0 with MP3 support?

@faroit
Copy link
Contributor Author

faroit commented May 20, 2022

A user in bastibe/python-soundfile#325 just reported that the M1 binary you provided seems to lack MP3 support. Did you compile it from the version of mac_build.sh from the 1.1.0 branch?

yes, i did. But u just wanted to be quick and didn't test the build. Will get into it now

@faroit
Copy link
Contributor Author

faroit commented May 20, 2022

checking for lame/lame.h... no
checking for library containing lame_set_VBR_q... no
configure: WARNING: "MPEG support selected but external Lame library cannot be found.
checking for libmpg123 >= 1.25.10 ... yes

configure: WARNING: *** MPEG support disabled.

checking processor clipping capabilities... none

found it.

@bastibe @adrian-stepien

@faroit
Copy link
Contributor Author

faroit commented May 20, 2022

I think this was addressed here: libsndfile/libsndfile#822

@faroit
Copy link
Contributor Author

faroit commented May 20, 2022

@bastibe @adrian-stepien

  1. wait for the next release?
  2. modify this repo to install from github source?
  3. do 1. but me or adrian build just binaries locally and push them to this pr?

@bastibe
Copy link
Owner

bastibe commented May 20, 2022

Thank you for looking into this!

Is this somehow M1 specific? It seems that the CI build on macOS/intel does not seem to run into this issue for whatever reason: https://github.com/bastibe/libsndfile-binaries/runs/6469425537?check_suite_focus=true

I'd be in favor of building a patched library now, and possibly deploy an update once the fix is published upstream.

But please do not feel pressured or rushed to do this super quickly. The next release of soundfile has been in the works for several months, and it can wait a little longer, I'm sure. Open source should be fun, not stress!

@faroit
Copy link
Contributor Author

faroit commented May 20, 2022

I tried a bunch of things but i can't make configure finding the lame headers. @adrian-stepien maybe you have more luck

@faroit
Copy link
Contributor Author

faroit commented May 27, 2022

@bastibe You have more ideas now make configure find the lame headers?

@bastibe
Copy link
Owner

bastibe commented May 30, 2022

Honestly, I have no idea. Could you post the output of the mac_build.sh script? Perhaps a path changed or something...

@faroit faroit mentioned this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants