-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add macos arm64 build #12
add macos arm64 build #12
Conversation
Brilliant! Thank you so much! |
A user in bastibe/python-soundfile#325 just reported that the M1 binary you provided seems to lack MP3 support. Did you compile it from the version of mac_build.sh from the 1.1.0 branch? And might I ask once more for your help compiling an M1 binary for 1.1.0 with MP3 support? |
yes, i did. But u just wanted to be quick and didn't test the build. Will get into it now |
found it. |
I think this was addressed here: libsndfile/libsndfile#822 |
|
Thank you for looking into this! Is this somehow M1 specific? It seems that the CI build on macOS/intel does not seem to run into this issue for whatever reason: https://github.com/bastibe/libsndfile-binaries/runs/6469425537?check_suite_focus=true I'd be in favor of building a patched library now, and possibly deploy an update once the fix is published upstream. But please do not feel pressured or rushed to do this super quickly. The next release of soundfile has been in the works for several months, and it can wait a little longer, I'm sure. Open source should be fun, not stress! |
I tried a bunch of things but i can't make configure finding the lame headers. @adrian-stepien maybe you have more luck |
@bastibe You have more ideas now make configure find the lame headers? |
Honestly, I have no idea. Could you post the output of the mac_build.sh script? Perhaps a path changed or something... |
--enable-werror
from script