Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
vertexclique committed Nov 3, 2019
1 parent 5628389 commit c8792a9
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 9 deletions.
2 changes: 1 addition & 1 deletion bastion-executor/src/blocking_pool.rs
Original file line number Diff line number Diff line change
@@ -1 +1 @@

// FIXME: Blocking pool implementation goes here.
1 change: 1 addition & 0 deletions bastion-executor/src/pool.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ pub struct Pool {
impl Pool {
/// Error recovery for the fallen threads
pub fn recover_async_thread() {
// FIXME: Do recovery for fallen worker threads
unimplemented!()
}

Expand Down
7 changes: 0 additions & 7 deletions bastion-executor/src/run.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,6 @@ where
let _child_id = stack.get_pid();
let _parent_id = worker::get_proc_stack(|t| t.get_pid()).unwrap_or(0);

// Wrap the future into one that drops task-local variables on exit.
// let future = task_local::add_finalizer(future);

let future = async move {
future.await;
};

// Pin the future onto the stack.
pin_utils::pin_mut!(future);

Expand Down
2 changes: 1 addition & 1 deletion bastion-executor/src/thread_recovery.rs
Original file line number Diff line number Diff line change
@@ -1 +1 @@

// FIXME: Thread recovery for worker code will go here

0 comments on commit c8792a9

Please sign in to comment.