Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split children into four modules: children, children_ref, child, child_ref #144

Merged
merged 2 commits into from
Dec 26, 2019
Merged

Split children into four modules: children, children_ref, child, child_ref #144

merged 2 commits into from
Dec 26, 2019

Conversation

onsails
Copy link
Member

@onsails onsails commented Dec 26, 2019

Checklist
  • tests are passing with cargo test.
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message is clear

@onsails onsails changed the title Split children into four modules: childrenn, children_ref, child, child_ref Split children into four modules: children, children_ref, child, child_ref Dec 26, 2019
vertexclique
vertexclique approved these changes Dec 26, 2019
View reviewed changes
Copy link
Member

@vertexclique vertexclique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for encapsulation and other little tidbits.

@onsails onsails merged commit aab2c00 into master Dec 26, 2019
@vertexclique vertexclique deleted the split-children branch December 26, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vertexclique vertexclique vertexclique approved these changes

@r3v2d0g r3v2d0g Awaiting requested review from r3v2d0g

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onsails @vertexclique