Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: try with 3.11 and 3.12 #902

Merged
merged 1 commit into from
Dec 16, 2023
Merged

CI: try with 3.11 and 3.12 #902

merged 1 commit into from
Dec 16, 2023

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Dec 16, 2023

Fix python/cpython#100458

Fix a pandas incompatibility

@batfish-bot
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Merging #902 (d5d54df) into master (ea524b3) will not change coverage.
The diff coverage is 83.33%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #902    +/-   ##
========================================
  Coverage   85.54%   85.54%            
========================================
  Files          30       30            
  Lines        3977     3977            
  Branches      664      817   +153     
========================================
  Hits         3402     3402            
  Misses        430      430            
  Partials      145      145            
Files Coverage Δ
pybatfish/client/asserts.py 91.94% <100.00%> (-0.07%) ⬇️
pybatfish/client/restv2helper.py 70.18% <ø> (ø)
pybatfish/question/question.py 82.66% <82.50%> (+0.07%) ⬆️

@dhalperi dhalperi force-pushed the spr/master/f0b690de branch 7 times, most recently from 5184595 to 2274fd9 Compare December 16, 2023 20:18
Fix python/cpython#100458

Fix a pandas incompatibility

commit-id:f0b690de
Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@dhalperi dhalperi merged commit e238298 into master Dec 16, 2023
31 of 32 checks passed
@dhalperi dhalperi deleted the spr/master/f0b690de branch December 16, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enum with str or int Mixin Breaking Change in Python 3.11
2 participants