add kernel patches for asus-armoury and hid-asus-ally #12274
There are no files selected for viewing
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| From bd44a3974570b483192c9414faaa4d4dd86f9f9e Mon Sep 17 00:00:00 2001 | ||
| From: Jonathan LoBue <jlobue10@gmail.com> | ||
| Date: Sat, 13 Jul 2024 00:12:06 -0700 | ||
| Subject: [PATCH] Fix ROG ALLY X audio | ||
|
|
||
| Patch to test fixing TAS2781 amp getting bound properly to i2c | ||
| for ASUS ROG ALLY X. | ||
| --- | ||
| sound/pci/hda/patch_realtek.c | 8 ++++++++ | ||
| 1 file changed, 8 insertions(+) | ||
|
|
||
| diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c | ||
| index 766f0b1d3e9d6..8d118df273f81 100644 | ||
| --- a/sound/pci/hda/patch_realtek.c | ||
| +++ b/sound/pci/hda/patch_realtek.c | ||
| @@ -7409,6 +7409,7 @@ enum { | ||
| ALC285_FIXUP_THINKPAD_X1_GEN7, | ||
| ALC285_FIXUP_THINKPAD_HEADSET_JACK, | ||
| ALC294_FIXUP_ASUS_ALLY, | ||
| + ALC294_FIXUP_ASUS_ALLY_X, | ||
| ALC294_FIXUP_ASUS_ALLY_PINS, | ||
| ALC294_FIXUP_ASUS_ALLY_VERBS, | ||
| ALC294_FIXUP_ASUS_ALLY_SPEAKER, | ||
| @@ -8875,6 +8876,12 @@ static const struct hda_fixup alc269_fixups[] = { | ||
| .chained = true, | ||
| .chain_id = ALC294_FIXUP_ASUS_ALLY_PINS | ||
| }, | ||
| + [ALC294_FIXUP_ASUS_ALLY_X] = { | ||
| + .type = HDA_FIXUP_FUNC, | ||
| + .v.func = tas2781_fixup_i2c, | ||
| + .chained = true, | ||
| + .chain_id = ALC294_FIXUP_ASUS_ALLY_PINS | ||
| + }, | ||
| [ALC294_FIXUP_ASUS_ALLY_PINS] = { | ||
| .type = HDA_FIXUP_PINS, | ||
| .v.pins = (const struct hda_pintbl[]) { | ||
| @@ -10306,6 +10313,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { | ||
| SND_PCI_QUIRK(0x1043, 0x1740, "ASUS UX430UA", ALC295_FIXUP_ASUS_DACS), | ||
| SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", ALC294_FIXUP_ASUS_DUAL_SPK), | ||
| SND_PCI_QUIRK(0x1043, 0x17f3, "ROG Ally NR2301L/X", ALC294_FIXUP_ASUS_ALLY), | ||
| + SND_PCI_QUIRK(0x1043, 0x1eb3, "ROG Ally X RC72LA", ALC294_FIXUP_ASUS_ALLY_X), | ||
| SND_PCI_QUIRK(0x1043, 0x1863, "ASUS UX6404VI/VV", ALC245_FIXUP_CS35L41_SPI_2), | ||
| SND_PCI_QUIRK(0x1043, 0x1881, "ASUS Zephyrus S/M", ALC294_FIXUP_ASUS_GX502_PINS), | ||
| SND_PCI_QUIRK(0x1043, 0x18b1, "Asus MJ401TA", ALC256_FIXUP_ASUS_HEADSET_MIC), | ||
| -- | ||
| GitLab | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| From 189db56a622c6706cf062a09910fb676f891500d Mon Sep 17 00:00:00 2001 | ||
| From: "Luke D. Jones" <luke@ljones.dev> | ||
| Date: Tue, 18 Jun 2024 16:22:33 +1200 | ||
| Subject: [PATCH] Add azoth | ||
|
|
||
| --- | ||
| drivers/hid/hid-asus.c | 3 +++ | ||
| drivers/hid/hid-ids.h | 1 + | ||
| 2 files changed, 4 insertions(+) | ||
|
|
||
| diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c | ||
| index 37e6d25593c21..08ed87d74912c 100644 | ||
| --- a/drivers/hid/hid-asus.c | ||
| +++ b/drivers/hid/hid-asus.c | ||
| @@ -1248,6 +1248,9 @@ static const struct hid_device_id asus_devices[] = { | ||
| { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, | ||
| USB_DEVICE_ID_ASUSTEK_ROG_NKEY_ALLY), | ||
| QUIRK_USE_KBD_BACKLIGHT | QUIRK_ROG_NKEY_KEYBOARD }, | ||
| + { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, | ||
| + USB_DEVICE_ID_ASUSTEK_ROG_AZOTH_KEYBOARD), | ||
| + QUIRK_USE_KBD_BACKLIGHT | QUIRK_ROG_NKEY_KEYBOARD }, | ||
| { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, | ||
| USB_DEVICE_ID_ASUSTEK_ROG_CLAYMORE_II_KEYBOARD), | ||
| QUIRK_ROG_CLAYMORE_II_KEYBOARD }, | ||
| diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h | ||
| index 72d56ee7ce1b9..4bcf3979782cd 100644 | ||
| --- a/drivers/hid/hid-ids.h | ||
| +++ b/drivers/hid/hid-ids.h | ||
| @@ -210,6 +210,7 @@ | ||
| #define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_KEYBOARD3 0x1a30 | ||
| #define USB_DEVICE_ID_ASUSTEK_ROG_Z13_LIGHTBAR 0x18c6 | ||
| #define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_ALLY 0x1abe | ||
| +#define USB_DEVICE_ID_ASUSTEK_ROG_AZOTH_KEYBOARD 0x1a83 | ||
| #define USB_DEVICE_ID_ASUSTEK_ROG_CLAYMORE_II_KEYBOARD 0x196b | ||
| #define USB_DEVICE_ID_ASUSTEK_FX503VD_KEYBOARD 0x1869 | ||
|
|
||
| -- | ||
| GitLab | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| From 170ce5748a6cee038488633196ead1843aa083ed Mon Sep 17 00:00:00 2001 | ||
| From: "Luke D. Jones" <luke@ljones.dev> | ||
| Date: Fri, 7 Jun 2024 15:58:01 +1200 | ||
| Subject: [PATCH] Input: xpad - add support for ASUS ROG RAIKIRI PRO | ||
|
|
||
| Add the VID/PID for ASUS ROG RAIKIRI PRO to | ||
| xpad_device and the VID to xpad_table. | ||
|
|
||
| Signed-off-by: Luke D. Jones <luke@ljones.dev> | ||
| --- | ||
| drivers/hid/hid-ids.h | 1 + | ||
| 1 file changed, 1 insertion(+) | ||
|
|
||
| diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h | ||
| index 4bcf3979782cd..fdf2d480533bf 100644 | ||
| --- a/drivers/hid/hid-ids.h | ||
| +++ b/drivers/hid/hid-ids.h | ||
| @@ -209,6 +209,7 @@ | ||
| #define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_KEYBOARD2 0x19b6 | ||
| #define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_KEYBOARD3 0x1a30 | ||
| #define USB_DEVICE_ID_ASUSTEK_ROG_Z13_LIGHTBAR 0x18c6 | ||
| +#define USB_DEVICE_ID_ASUSTEK_ROG_RAIKIRI_PAD 0x1abb | ||
| #define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_ALLY 0x1abe | ||
| #define USB_DEVICE_ID_ASUSTEK_ROG_AZOTH_KEYBOARD 0x1a83 | ||
| #define USB_DEVICE_ID_ASUSTEK_ROG_CLAYMORE_II_KEYBOARD 0x196b | ||
| -- | ||
| GitLab | ||
|
|
|
There was a problem hiding this comment. ok, how is this controlled? or is that for future discussions? There was a problem hiding this comment. That will be future discussions |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| From cc8e85eb8454a45633565d4a867919a9e17216e8 Mon Sep 17 00:00:00 2001 | ||
| From: "Luke D. Jones" <luke@ljones.dev> | ||
| Date: Mon, 13 May 2024 19:20:04 +1200 | ||
| Subject: [PATCH] hid-asus: use hid for brightness control on keyboard | ||
|
|
||
| On almost all ASUS ROG series laptops the MCU used for the USB keyboard | ||
| also has a HID packet used for setting the brightness. This is usually | ||
| the same as the WMI method. But in some laptops the WMI method either | ||
| is missing or doesn't work, so we should default to the HID control. | ||
|
|
||
| Signed-off-by: Luke D. Jones <luke@ljones.dev> | ||
| --- | ||
| drivers/hid/hid-asus.c | 7 +++++ | ||
| drivers/platform/x86/asus-wmi.c | 3 +- | ||
| include/linux/platform_data/x86/asus-wmi.h | 36 ++++++++++++++++++++++ | ||
| 3 files changed, 45 insertions(+), 1 deletion(-) | ||
|
|
||
| diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c | ||
| index 08ed87d74912c..9010f12a221ea 100644 | ||
| --- a/drivers/hid/hid-asus.c | ||
| +++ b/drivers/hid/hid-asus.c | ||
| @@ -492,12 +492,19 @@ static void asus_kbd_backlight_work(struct work_struct *work) | ||
| */ | ||
| static bool asus_kbd_wmi_led_control_present(struct hid_device *hdev) | ||
| { | ||
| + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); | ||
| u32 value; | ||
| int ret; | ||
|
|
||
| if (!IS_ENABLED(CONFIG_ASUS_WMI)) | ||
| return false; | ||
|
|
||
| + if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD && | ||
| + dmi_check_system(asus_use_hid_led_dmi_ids)) { | ||
| + hid_info(hdev, "using HID for asus::kbd_backlight\n"); | ||
| + return false; | ||
| + } | ||
| + | ||
| ret = asus_wmi_evaluate_method(ASUS_WMI_METHODID_DSTS, | ||
| ASUS_WMI_DEVID_KBD_BACKLIGHT, 0, &value); | ||
| hid_dbg(hdev, "WMI backlight check: rc %d value %x", ret, value); | ||
| diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c | ||
| index 3f9b6285c9a66..799d928c7d3d0 100644 | ||
| --- a/drivers/platform/x86/asus-wmi.c | ||
| +++ b/drivers/platform/x86/asus-wmi.c | ||
| @@ -1681,7 +1681,8 @@ static int asus_wmi_led_init(struct asus_wmi *asus) | ||
| goto error; | ||
| } | ||
|
|
||
| - if (!kbd_led_read(asus, &led_val, NULL)) { | ||
| + if (!kbd_led_read(asus, &led_val, NULL) && !dmi_check_system(asus_use_hid_led_dmi_ids)) { | ||
| + pr_info("using asus-wmi for asus::kbd_backlight\n"); | ||
| asus->kbd_led_wk = led_val; | ||
| asus->kbd_led.name = "asus::kbd_backlight"; | ||
| asus->kbd_led.flags = LED_BRIGHT_HW_CHANGED; | ||
| diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h | ||
| index 3eb5cd6773ad4..74b32e1d67350 100644 | ||
| --- a/include/linux/platform_data/x86/asus-wmi.h | ||
| +++ b/include/linux/platform_data/x86/asus-wmi.h | ||
| @@ -4,6 +4,7 @@ | ||
|
|
||
| #include <linux/errno.h> | ||
| #include <linux/types.h> | ||
| +#include <linux/dmi.h> | ||
|
|
||
| /* WMI Methods */ | ||
| #define ASUS_WMI_METHODID_SPEC 0x43455053 /* BIOS SPECification */ | ||
| @@ -160,4 +161,39 @@ static inline int asus_wmi_evaluate_method(u32 method_id, u32 arg0, u32 arg1, | ||
| } | ||
| #endif | ||
|
|
||
| +/* To be used by both hid-asus and asus-wmi to determine which controls kbd_brightness */ | ||
| +static const struct dmi_system_id asus_use_hid_led_dmi_ids[] = { | ||
| + { | ||
| + .matches = { | ||
| + DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Zephyrus"), | ||
| + }, | ||
| + }, | ||
| + { | ||
| + .matches = { | ||
| + DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Strix"), | ||
| + }, | ||
| + }, | ||
| + { | ||
| + .matches = { | ||
| + DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Flow"), | ||
| + }, | ||
| + }, | ||
| + { | ||
| + .matches = { | ||
| + DMI_MATCH(DMI_BOARD_NAME, "GA403U"), | ||
| + }, | ||
| + }, | ||
| + { | ||
| + .matches = { | ||
| + DMI_MATCH(DMI_BOARD_NAME, "GU605M"), | ||
| + }, | ||
| + }, | ||
| + { | ||
| + .matches = { | ||
| + DMI_MATCH(DMI_BOARD_NAME, "RC71L"), | ||
| + }, | ||
| + }, | ||
| + { }, | ||
| +}; | ||
| + | ||
| #endif /* __PLATFORM_DATA_X86_ASUS_WMI_H */ | ||
| -- | ||
| GitLab | ||
|
|
|
There was a problem hiding this comment. do we need this included? There was a problem hiding this comment. Probably not. I'll remove it and renumber. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,164 @@ | ||
| From 038cc096a2bc435bd9e21958ab38997da4bbc997 Mon Sep 17 00:00:00 2001 | ||
| From: "Luke D. Jones" <luke@ljones.dev> | ||
| Date: Tue, 21 May 2024 18:17:17 +1200 | ||
| Subject: [PATCH] platform/x86: asus-wmi: add debug print in more key places | ||
|
|
||
| Add more verbose debug print in the WMI method calls. This helps a lot | ||
| with debugging various issues working with regular users as the WMI | ||
| methods can be traced now. | ||
|
|
||
| Signed-off-by: Luke D. Jones <luke@ljones.dev> | ||
| --- | ||
| drivers/platform/x86/asus-wmi.c | 58 +++++++++++++++++++++++++++------ | ||
| 1 file changed, 48 insertions(+), 10 deletions(-) | ||
|
|
||
| diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c | ||
| index 799d928c7d3d0..4c129881ce280 100644 | ||
| --- a/drivers/platform/x86/asus-wmi.c | ||
| +++ b/drivers/platform/x86/asus-wmi.c | ||
| @@ -334,20 +334,29 @@ static int asus_wmi_evaluate_method3(u32 method_id, | ||
| status = wmi_evaluate_method(ASUS_WMI_MGMT_GUID, 0, method_id, | ||
| &input, &output); | ||
|
|
||
| - if (ACPI_FAILURE(status)) | ||
| + pr_debug("%s called (0x%08x) with args: 0x%08x, 0x%08x, 0x%08x\n", | ||
| + __func__, method_id, arg0, arg1, arg2); | ||
| + if (ACPI_FAILURE(status)) { | ||
| + pr_debug("%s, (0x%08x), arg 0x%08x failed: %d\n", | ||
| + __func__, method_id, arg0, -EIO); | ||
| return -EIO; | ||
| + } | ||
|
|
||
| obj = (union acpi_object *)output.pointer; | ||
| if (obj && obj->type == ACPI_TYPE_INTEGER) | ||
| tmp = (u32) obj->integer.value; | ||
|
|
||
| + pr_debug("Result: 0x%08x\n", tmp); | ||
| if (retval) | ||
| *retval = tmp; | ||
|
|
||
| kfree(obj); | ||
|
|
||
| - if (tmp == ASUS_WMI_UNSUPPORTED_METHOD) | ||
| + if (tmp == ASUS_WMI_UNSUPPORTED_METHOD) { | ||
| + pr_debug("%s, (0x%08x), arg 0x%08x failed: %d\n", | ||
| + __func__, method_id, arg0, -ENODEV); | ||
| return -ENODEV; | ||
| + } | ||
|
|
||
| return 0; | ||
| } | ||
| @@ -377,20 +386,29 @@ static int asus_wmi_evaluate_method5(u32 method_id, | ||
| status = wmi_evaluate_method(ASUS_WMI_MGMT_GUID, 0, method_id, | ||
| &input, &output); | ||
|
|
||
| - if (ACPI_FAILURE(status)) | ||
| + pr_debug("%s called (0x%08x) with args: 0x%08x, 0x%08x, 0x%08x, 0x%08x, 0x%08x\n", | ||
| + __func__, method_id, arg0, arg1, arg2, arg3, arg4); | ||
| + if (ACPI_FAILURE(status)) { | ||
| + pr_debug("%s, (0x%08x), arg 0x%08x failed: %d\n", | ||
| + __func__, method_id, arg0, -EIO); | ||
| return -EIO; | ||
| + } | ||
|
|
||
| obj = (union acpi_object *)output.pointer; | ||
| if (obj && obj->type == ACPI_TYPE_INTEGER) | ||
| tmp = (u32) obj->integer.value; | ||
|
|
||
| + pr_debug("Result: %x\n", tmp); | ||
| if (retval) | ||
| *retval = tmp; | ||
|
|
||
| kfree(obj); | ||
|
|
||
| - if (tmp == ASUS_WMI_UNSUPPORTED_METHOD) | ||
| + if (tmp == ASUS_WMI_UNSUPPORTED_METHOD) { | ||
| + pr_debug("%s, (0x%08x), arg 0x%08x failed: %d\n", | ||
| + __func__, method_id, arg0, -ENODEV); | ||
| return -ENODEV; | ||
| + } | ||
|
|
||
| return 0; | ||
| } | ||
| @@ -416,8 +434,13 @@ static int asus_wmi_evaluate_method_buf(u32 method_id, | ||
| status = wmi_evaluate_method(ASUS_WMI_MGMT_GUID, 0, method_id, | ||
| &input, &output); | ||
|
|
||
| - if (ACPI_FAILURE(status)) | ||
| + pr_debug("%s called (0x%08x) with args: 0x%08x, 0x%08x\n", | ||
| + __func__, method_id, arg0, arg1); | ||
| + if (ACPI_FAILURE(status)) { | ||
| + pr_debug("%s, (0x%08x), arg 0x%08x failed: %d\n", | ||
| + __func__, method_id, arg0, -EIO); | ||
| return -EIO; | ||
| + } | ||
|
|
||
| obj = (union acpi_object *)output.pointer; | ||
|
|
||
| @@ -453,8 +476,11 @@ static int asus_wmi_evaluate_method_buf(u32 method_id, | ||
|
|
||
| kfree(obj); | ||
|
|
||
| - if (err) | ||
| + if (err) { | ||
| + pr_debug("%s, (0x%08x), arg 0x%08x failed: %d\n", | ||
| + __func__, method_id, arg0, err); | ||
| return err; | ||
| + } | ||
|
|
||
| return 0; | ||
| } | ||
| @@ -542,6 +568,7 @@ static bool asus_wmi_dev_is_present(struct asus_wmi *asus, u32 dev_id) | ||
| { | ||
| u32 retval; | ||
| int status = asus_wmi_get_devstate(asus, dev_id, &retval); | ||
| + pr_debug("%s called (0x%08x), retval: 0x%08x\n", __func__, dev_id, retval); | ||
|
|
||
| return status == 0 && (retval & ASUS_WMI_DSTS_PRESENCE_BIT); | ||
| } | ||
| @@ -3559,18 +3586,27 @@ static int asus_wmi_custom_fan_curve_init(struct asus_wmi *asus) | ||
|
|
||
| err = fan_curve_check_present(asus, &asus->cpu_fan_curve_available, | ||
| ASUS_WMI_DEVID_CPU_FAN_CURVE); | ||
| - if (err) | ||
| + if (err) { | ||
| + pr_err("%s, checked 0x%08x, failed: %d\n", | ||
| + __func__, ASUS_WMI_DEVID_CPU_FAN_CURVE, err); | ||
| return err; | ||
| + } | ||
|
|
||
| err = fan_curve_check_present(asus, &asus->gpu_fan_curve_available, | ||
| ASUS_WMI_DEVID_GPU_FAN_CURVE); | ||
| - if (err) | ||
| + if (err) { | ||
| + pr_err("%s, checked 0x%08x, failed: %d\n", | ||
| + __func__, ASUS_WMI_DEVID_GPU_FAN_CURVE, err); | ||
| return err; | ||
| + } | ||
|
|
||
| err = fan_curve_check_present(asus, &asus->mid_fan_curve_available, | ||
| ASUS_WMI_DEVID_MID_FAN_CURVE); | ||
| - if (err) | ||
| + if (err) { | ||
| + pr_err("%s, checked 0x%08x, failed: %d\n", | ||
| + __func__, ASUS_WMI_DEVID_MID_FAN_CURVE, err); | ||
| return err; | ||
| + } | ||
|
|
||
| if (!asus->cpu_fan_curve_available | ||
| && !asus->gpu_fan_curve_available | ||
| @@ -4398,8 +4434,10 @@ static umode_t asus_sysfs_is_visible(struct kobject *kobj, | ||
| else if (attr == &dev_attr_available_mini_led_mode.attr) | ||
| ok = asus->mini_led_dev_id != 0; | ||
|
|
||
| - if (devid != -1) | ||
| + if (devid != -1) { | ||
| ok = !(asus_wmi_get_devstate_simple(asus, devid) < 0); | ||
| + pr_debug("%s called 0x%08x, ok: %x\n", __func__, devid, ok); | ||
| + } | ||
|
|
||
| return ok ? attr->mode : 0; | ||
| } | ||
| -- | ||
| GitLab | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is included in 6.10.3