Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [board/batocera] initial work to get clockworkpi gameshell support #5887

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arthurlutz
Copy link

No description provided.

@arthurlutz arthurlutz changed the base branch from 33 to master March 28, 2022 14:01
@arthurlutz
Copy link
Author

Related forum posts : https://forum.batocera.org/d/7337-batocera-on-clockworkpi-gameshell-hardware & https://forum.clockworkpi.com/t/what-would-it-take-to-run-batocera-on-the-gameshell/8113

This is work in progress, but I'd like to submit it early to get some feedback and maybe some help on how to work on this.

@nadenislamarre
Copy link
Collaborator

it looks good.
for scummvm, why did you add !BR2_PACKAGE_BATOCERA_TARGET_ORANGEPI_PC ?

@arthurlutz
Copy link
Author

For scummvm I feel like mouse point-n-click games on a devices that (by default) does not have a mouse would be OK. If once we get an initial image going someone comes along and says "hey I can plug in a mouse or use only the gamepad" then why not enable it.

@Hew-ux
Copy link

Hew-ux commented Mar 31, 2022

The approach is "for all systems that build, leave enabled", such that if the user decides they want to use it, then they can do so. If there are requirements for a system to be fully operational on a particular platform, then they can be mentioned in the wiki.

Example (which actually covers your device I believe): https://wiki.batocera.org/remapping_controls_per_emulator

@@ -510,7 +518,7 @@ config BR2_PACKAGE_BATOCERA_SCUMMVM_SYSTEMS
bool "batocera.linux ScummVM emulators/cores"

# ScummVM
select BR2_PACKAGE_SCUMMVM if !BR2_PACKAGE_BATOCERA_TARGET_RPI1 && !BR2_PACKAGE_BATOCERA_TARGET_RPIZERO2
select BR2_PACKAGE_SCUMMVM if !BR2_PACKAGE_BATOCERA_TARGET_RPI1 && !BR2_PACKAGE_BATOCERA_TARGET_RPIZERO2 && !BR2_PACKAGE_BATOCERA_TARGET_CLOCKWORKPI
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
select BR2_PACKAGE_SCUMMVM if !BR2_PACKAGE_BATOCERA_TARGET_RPI1 && !BR2_PACKAGE_BATOCERA_TARGET_RPIZERO2 && !BR2_PACKAGE_BATOCERA_TARGET_CLOCKWORKPI
select BR2_PACKAGE_SCUMMVM if !BR2_PACKAGE_BATOCERA_TARGET_RPI1 && !BR2_PACKAGE_BATOCERA_TARGET_RPIZERO2

@arthurlutz
Copy link
Author

I have two .dtb files that are not in the upstream linux kernel. Right now I'm copying them by hand from https://github.com/wolfallein/clockworkpi-debian/blob/master/bin/kernel/5.7/ or https://github.com/clockworkpi/Kernel/tree/master/CPI3_linux_4.20 to compile the kernel. What would be the recommended way of including those in the build process ? (I can't find any other examples where the dtb is not in the upstream kernel).

@Hew-ux
Copy link

Hew-ux commented Apr 3, 2022

I had to do this recently for RPi3 actually. Take a look at #5812

The DTB source code will usually have the instructions on what to do.

@nadenislamarre
Copy link
Collaborator

if you copy them to the kernel sources, the easier way is to do a patch.
or
like here : https://github.com/batocera-linux/batocera.linux/blob/master/configs/batocera-rk3326_defconfig#L51

@arthurlutz
Copy link
Author

Thanks for your tips. I now get to compile and build the image (even though there are still some things I don't fully understand). The image doesn't boot on the device (yet), but I'll soon have an UART to figure out what is going on. When swapping the linux file (kernel) with the working one the screen turn on and flickers, so there is part of it working.

On the working image (clockworkOS) I have a /boot.src file, is that required with batocera or not ?

@n2qz n2qz marked this pull request as draft December 24, 2023 03:25
@n2qz n2qz added the conflicts label Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants