Make bats-file safe to use under -u #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't make the merge dependent on a successful CI build. As far as I can tell, the build is broken for reasons unrelated to this commit. |
|
Hi @sublimino! |
martin-schulze-vireso
force-pushed
the
allow-set-u
branch
from
b7db90e
to
ea63ece
Compare
martin-schulze-vireso
approved these changes
Mar 6, 2022
Use '${BATSLIB_FILE_PATH_REM-}' instead of '$BATSLIB_FILE_PATH_REM'.
Use "set -u" in all tests to avoid regressions.
martin-schulze-vireso
force-pushed
the
allow-set-u
branch
from
ea63ece
to
9aefab4
Compare
|
Thanks for your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
${BATSLIB_FILE_PATH_REM-}instead of$BATSLIB_FILE_PATH_REM.Use
set -uin all tests to avoid regressions.Fixes #32