Added a note to the README #169
Conversation
Added a clarification on the chace paragraph to Highlight that a reboot is still necessary
|
Can we just change the first line to add the sentence:
Perhaps you could add a note after the Caching command line examples section headers along these lines to address the other thing you ran into.
Sound good? |
|
@klmcwhirter Sound good, I will make another commit. |
README.md
Outdated
| @@ -172,6 +172,8 @@ Show cache created by EnvyControl | |||
| sudo envycontrol --cache-query | |||
| ``` | |||
|
|
|||
| >[!NOTE] | |||
There was a problem hiding this comment.
Can we remove this special callout now - just the [!NOTE]? This is not done anywhere else in the README.
I do not feel really strongly about this comment. Just trying to protect the existing document style choices. I can be easily swayed to keep it if you feel it is really needed.
And can this be moved right under the section header - after the blank line in line 131?
@bayasdev can you weigh in here please?
There was a problem hiding this comment.
Sorry, we can remove the [!NOTE] to stick with the document style, however I would also make the note as a standard paragraph after the blank line in line 131.
| @@ -125,7 +125,7 @@ sudo envycontrol --reset | |||
| ``` | |||
|
|
|||
| ### Caching added with 3.4.0 | |||
| A cache was added in version 3.4.0. The main purpose is to cache the Nvidia PCI bus ID so that a transition from integrated mode directly to nvidia mode is possible. | |||
| A cache was added in version 3.4.0. The main purpose is to cache the Nvidia PCI bus ID so that a transition from integrated mode directly to nvidia mode is possible. A reboot is required as usual so the changes can take effect. | |||
There was a problem hiding this comment.
Thanks for making this change. This feels more concise now.
Added a clarification on the cache paragraph to Highlight that a reboot is still necessary.
This is for potatoes like me who believe they can switch from integrated to nvidia without having to reboot