-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bzlmod: Remove deprecated override attributes on go_deps.module
#1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@seh Could you take a look? |
seh
approved these changes
May 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to see the evolution progressing as promised.
fmeum
force-pushed
the
remove-override-attrs
branch
from
May 28, 2023 12:34
5e03bdf
to
4e2485e
Compare
@linzhp Could you test at Uber? |
fmeum
force-pushed
the
remove-override-attrs
branch
from
May 28, 2023 12:39
4e2485e
to
b6b4cf5
Compare
tyler-french
approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested at Uber (cc @linzhp)
renovate bot
referenced
this pull request
in kreempuff/rules_unreal_engine
Jun 13, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | patch | `v0.31.0` -> `v0.31.1` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle</summary> ### [`v0.31.1`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.31.1) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.31.0...v0.31.1) #### What's Changed - point sync.Once in walkConfig by [@​jmhodges](https://togithub.com/jmhodges) in [https://github.com/bazelbuild/bazel-gazelle/pull/1532](https://togithub.com/bazelbuild/bazel-gazelle/pull/1532) - add copylock vet to nogo by [@​jmhodges](https://togithub.com/jmhodges) in [https://github.com/bazelbuild/bazel-gazelle/pull/1534](https://togithub.com/bazelbuild/bazel-gazelle/pull/1534) - bzlmod: Remove deprecated override attributes on `go_deps.module` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1548](https://togithub.com/bazelbuild/bazel-gazelle/pull/1548) - Add default directives for github.com/envoyproxy/protoc-gen-validate by [@​mortenmj](https://togithub.com/mortenmj) in [https://github.com/bazelbuild/bazel-gazelle/pull/1553](https://togithub.com/bazelbuild/bazel-gazelle/pull/1553) - cmd/gazelle: do not use the epoch as timestamp in diff output by [@​siddharthab](https://togithub.com/siddharthab) in [https://github.com/bazelbuild/bazel-gazelle/pull/1552](https://togithub.com/bazelbuild/bazel-gazelle/pull/1552) - fileinfo: fix not detecting 'unix' files to be OS specific by [@​sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/bazel-gazelle/pull/1554](https://togithub.com/bazelbuild/bazel-gazelle/pull/1554) - language/go: Emit apparent repo name of rules_go in select keys by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1555](https://togithub.com/bazelbuild/bazel-gazelle/pull/1555) - Let `bazel_dep`s replace Go deps by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1526](https://togithub.com/bazelbuild/bazel-gazelle/pull/1526) #### New Contributors - [@​mortenmj](https://togithub.com/mortenmj) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1553](https://togithub.com/bazelbuild/bazel-gazelle/pull/1553) **Full Changelog**: bazel-contrib/bazel-gazelle@v0.31.0...v0.31.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Jun 13, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | patch | `v0.31.0` -> `v0.31.1` | --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle</summary> ### [`v0.31.1`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.31.1) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.31.0...v0.31.1) #### What's Changed - point sync.Once in walkConfig by [@​jmhodges](https://togithub.com/jmhodges) in [https://github.com/bazelbuild/bazel-gazelle/pull/1532](https://togithub.com/bazelbuild/bazel-gazelle/pull/1532) - add copylock vet to nogo by [@​jmhodges](https://togithub.com/jmhodges) in [https://github.com/bazelbuild/bazel-gazelle/pull/1534](https://togithub.com/bazelbuild/bazel-gazelle/pull/1534) - bzlmod: Remove deprecated override attributes on `go_deps.module` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1548](https://togithub.com/bazelbuild/bazel-gazelle/pull/1548) - Add default directives for github.com/envoyproxy/protoc-gen-validate by [@​mortenmj](https://togithub.com/mortenmj) in [https://github.com/bazelbuild/bazel-gazelle/pull/1553](https://togithub.com/bazelbuild/bazel-gazelle/pull/1553) - cmd/gazelle: do not use the epoch as timestamp in diff output by [@​siddharthab](https://togithub.com/siddharthab) in [https://github.com/bazelbuild/bazel-gazelle/pull/1552](https://togithub.com/bazelbuild/bazel-gazelle/pull/1552) - fileinfo: fix not detecting 'unix' files to be OS specific by [@​sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/bazel-gazelle/pull/1554](https://togithub.com/bazelbuild/bazel-gazelle/pull/1554) - language/go: Emit apparent repo name of rules_go in select keys by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1555](https://togithub.com/bazelbuild/bazel-gazelle/pull/1555) - Let `bazel_dep`s replace Go deps by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1526](https://togithub.com/bazelbuild/bazel-gazelle/pull/1526) #### New Contributors - [@​mortenmj](https://togithub.com/mortenmj) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1553](https://togithub.com/bazelbuild/bazel-gazelle/pull/1553) **Full Changelog**: bazel-contrib/bazel-gazelle@v0.31.0...v0.31.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/cgrindel/rules_swift_package_manager). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in cgrindel/bazel-starlib
Jun 13, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | patch | `v0.31.0` -> `v0.31.1` | --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle</summary> ### [`v0.31.1`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.31.1) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.31.0...v0.31.1) #### What's Changed - point sync.Once in walkConfig by [@​jmhodges](https://togithub.com/jmhodges) in [https://github.com/bazelbuild/bazel-gazelle/pull/1532](https://togithub.com/bazelbuild/bazel-gazelle/pull/1532) - add copylock vet to nogo by [@​jmhodges](https://togithub.com/jmhodges) in [https://github.com/bazelbuild/bazel-gazelle/pull/1534](https://togithub.com/bazelbuild/bazel-gazelle/pull/1534) - bzlmod: Remove deprecated override attributes on `go_deps.module` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1548](https://togithub.com/bazelbuild/bazel-gazelle/pull/1548) - Add default directives for github.com/envoyproxy/protoc-gen-validate by [@​mortenmj](https://togithub.com/mortenmj) in [https://github.com/bazelbuild/bazel-gazelle/pull/1553](https://togithub.com/bazelbuild/bazel-gazelle/pull/1553) - cmd/gazelle: do not use the epoch as timestamp in diff output by [@​siddharthab](https://togithub.com/siddharthab) in [https://github.com/bazelbuild/bazel-gazelle/pull/1552](https://togithub.com/bazelbuild/bazel-gazelle/pull/1552) - fileinfo: fix not detecting 'unix' files to be OS specific by [@​sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/bazel-gazelle/pull/1554](https://togithub.com/bazelbuild/bazel-gazelle/pull/1554) - language/go: Emit apparent repo name of rules_go in select keys by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1555](https://togithub.com/bazelbuild/bazel-gazelle/pull/1555) - Let `bazel_dep`s replace Go deps by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/bazel-gazelle/pull/1526](https://togithub.com/bazelbuild/bazel-gazelle/pull/1526) #### New Contributors - [@​mortenmj](https://togithub.com/mortenmj) made their first contribution in [https://github.com/bazelbuild/bazel-gazelle/pull/1553](https://togithub.com/bazelbuild/bazel-gazelle/pull/1553) **Full Changelog**: bazel-contrib/bazel-gazelle@v0.31.0...v0.31.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/cgrindel/bazel-starlib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.