Support load fixing on struct members (dotexpr) instead of just callexpr #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
approved these changes
Nov 7, 2024
aaronsky
force-pushed
the
aaronsky/fix-loads-struct-members
branch
from
02d1508
to
b45f10d
Compare
fmeum
force-pushed
the
aaronsky/fix-loads-struct-members
branch
from
b45f10d
to
25b2e3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What package or component does this PR mostly affect?
What does this PR do? Why is it needed?
The changes introduced by #1164 largely support what I need – automatic loading of non-rule symbols from known loads – except it only supports
CallExpr. For imported struct fields, these are not automatically picked up, and the ergonomics of getting them loaded in Gazelle has been tricky for me. I am hoping this is a reasonable fix to this.Which issues(s) does this PR fix?
Fixes #1971
Other notes for review
I haven't written Go in a while so please forgive the mess.