feat: support jq 1.7 toolchain #520
Conversation
|
There are some issues with the use of |
kormide
force-pushed
the
jq-1.7
branch
4 times, most recently
from
8befbba
to
9a0f66b
Compare
lib/private/jq_toolchain.bzl
Outdated
| ], | ||
| ), | ||
| _JQ_PLATFORMS = { | ||
| "<1.7": { |
There was a problem hiding this comment.
if it's a breaking change, why bother preserving compat with older versions of jq?
There was a problem hiding this comment.
I was assuming we should still support older versions of jq with newer versions of bazel-lib. Wdyt?
There was a problem hiding this comment.
The breaking change only needs to be in stamping.
There was a problem hiding this comment.
Unless it provides some utility to users, it seems to me that we should take the opportunity to simplify our code. Unlike the yq upgrade we attempted, I think pretty much everyone will be happy to have only 1.7 now?
There was a problem hiding this comment.
I can't think of any utility it provides. I'll drop the old versions, and if a need becomes apparent then we can add back what I have here for pre-1.7 support.
kormide
force-pushed
the
jq-1.7
branch
2 times, most recently
from
18092b4
to
a7a5d30
Compare
Fixes #268
Type of change
For changes visible to end-users
$stamp[0].MY_VARIABLErather than$stamp.MY_VARIABLE.Test plan