fix: move flags that should only be set with bazel 6 to bazel6.bazelrc recommended settings #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kormide
reviewed
Jan 4, 2024
gregmagolan
force-pushed
the
remove_recommended_experimental_check_output_files
branch
from
8bfeab1
to
69c05de
Compare
gregmagolan
changed the title
gregmagolan
force-pushed
the
remove_recommended_experimental_check_output_files
branch
2 times, most recently
from
78c153d
to
7ef087b
Compare
…c recommended settings
gregmagolan
force-pushed
the
remove_recommended_experimental_check_output_files
branch
from
7ef087b
to
24a0211
Compare
alexeagle
approved these changes
Jan 4, 2024
alexeagle
deleted the
remove_recommended_experimental_check_output_files
branch
gregmagolan
added a commit
that referenced
this pull request
Jan 5, 2024
…c recommended settings (#711)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with "build without the bytes" and
--experimental_action_cache_store_output_metadatain Bazel 6 that was reported in this blog post has been resolved in Bazel 7 so that flag is not needed in bazel7.bazelrc recommended presets.A new issue with Bazel 7 with "build without the bytes" and
--noexperimental_check_output_fileswas found so that flag is moved to bazel6 only. See aspect-build/aspect-cli#594 for more info.Type of change
For changes visible to end-users
Suggested release notes are provided below:
--experimental_action_cache_store_output_metadataflag is moved to bazel6.bazelrc recommended flags as the undelrying issue was resolved in Bazel 7--noexperimental_check_output_filesis no longer in our general recommended performance flags as it break "build without the bytes" on Bazel 7.0.0. Instead it has been moved to bazel6.bazelrc recommended flags.Test plan
Resolved
--noexperimental_check_output_filesissue in aspect-cli repo: aspect-build/aspect-cli#594Tested
--noexperimental_check_output_fileswith Bazel 7 in aspect-cli repo: aspect-build/aspect-cli#595