chore(deps): upgrade to newest bsdtar #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
alexeagle-patch-2
branch
from
466ff2b
to
0acf0d0
Compare
thesayyn
approved these changes
Sep 17, 2024
fhanau
reviewed
Sep 18, 2024
| ), | ||
| "windows_amd64": ( | ||
| "https://github.com/libarchive/libarchive/releases/download/v3.7.4/libarchive-v3.7.4-amd64.zip", | ||
| "7ced6865d5e22e1dab0c3f3d65094d946ae505ec4e8db026f82c9e1c413f3c59", | ||
| "https://github.com/aspect-build/bsdtar-prebuilt/releases/download/v3.7.5/tar_windows_amd64.exe", |
There was a problem hiding this comment.
I think the binary here won't work on Windows as intended – based on file it is an ELF binary:
$ wget https://github.com/aspect-build/bsdtar-prebuilt/releases/download/v3.7.5/tar_windows_amd64.exe
$ file tar_windows_amd64.exe
tar_windows_amd64.exe: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, stripped
There was a problem hiding this comment.
Yeah sorry about that, I detected that problem before release here (CI is red on main on windows). Working on it...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #935