Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on nogo with a transition and delete go_tool_library #2374

Closed
jayconrod opened this issue Feb 18, 2020 · 4 comments · Fixed by #2474 or #2922
Closed

Depend on nogo with a transition and delete go_tool_library #2374

jayconrod opened this issue Feb 18, 2020 · 4 comments · Fixed by #2474 or #2922
Labels
enhancement go nogo

Comments

@jayconrod
Copy link
Contributor

Instead of having the toolchain depend on nogo, a common target like @io_bazel_rules_go//:go_context_data should depend on it. The dependency should transition to a configuration that doesn't depend on nogo. That would break the cyclic dependency.

With that change, we could deprecate go_tool_library, and we could drop a lot of the custom patching for analyses in org_golang_x_tools.

This would also make it possible to use an alternative nogo binary using a command-line flag.
@jayconrod jayconrod mentioned this issue Feb 18, 2020
Closed
@achew22
Copy link
Member

achew22 commented Feb 18, 2020

I believe this would also allow specifying custom nogo binaries on a per go_binary target basis as well which would be really nifty!

@jayconrod jayconrod added this to the v0.23 milestone Mar 20, 2020
@jayconrod jayconrod mentioned this issue Apr 3, 2020
Closed
@jayconrod jayconrod mentioned this issue May 4, 2020
Closed
jayconrod pushed a commit to jayconrod/rules_go that referenced this issue May 5, 2020
nogo: migrate to configuration transitions
0daa41c 
The nogo binary to use is now specified using a Starlark flag.
For example:

    bazel build --@io_bazel_rules_go//go/config:nogo=@io_bazel_rules_go//:tools_nogo //:hello

.bazelrc is now the recommended way to set this flag. Setting nogo in
go_register_toolchains will still work, though that function may be
deprecated soon. The flag overrides the go_register_toolchains
argument when both are set.

Updates bazel-contrib#2374
Fixes bazel-contrib#2470
jayconrod pushed a commit to jayconrod/rules_go that referenced this issue May 5, 2020
nogo: migrate to configuration transitions
b340891 
The nogo binary to use is now specified using a Starlark flag.
For example:

    bazel build --@io_bazel_rules_go//go/config:nogo=@io_bazel_rules_go//:tools_nogo //:hello

.bazelrc is now the recommended way to set this flag. Setting nogo in
go_register_toolchains will still work, though that function may be
deprecated soon. The flag overrides the go_register_toolchains
argument when both are set.

Updates bazel-contrib#2374
Fixes bazel-contrib#2470
@jayconrod jayconrod mentioned this issue May 5, 2020
Merged
jayconrod pushed a commit that referenced this issue May 5, 2020
nogo: migrate to configuration transitions (#2473)
8bdd81a 
The nogo binary to use is now specified using a Starlark flag.
For example:

    bazel build --@io_bazel_rules_go//go/config:nogo=@io_bazel_rules_go//:tools_nogo //:hello

.bazelrc is now the recommended way to set this flag. Setting nogo in
go_register_toolchains will still work, though that function may be
deprecated soon. The flag overrides the go_register_toolchains
argument when both are set.

Updates #2374
Fixes #2470
jayconrod pushed a commit to jayconrod/rules_go that referenced this issue May 5, 2020
nogo: stop using go_tool_library
91ac9e7 
nogo binaries no longer depend on themselves. Since bazel-contrib#2473, the nogo
rule uses a configuration transition to disable nogo for itself and
its dependencies.

This means there's no longer any need for go_tool_library rules for
analyzers and utility packages in org_golang_x_tools. So with this
change, tools_nogo depends on the regular go_library analyzers. The
documentation is updated not to mention go_tool_library anymore.

Additionally, this change replaces the go_tool_library targets in
org_golang_x_tools with aliases to the go_library targets. So nogo
targets that depends on the old symbols should work.

Fixes bazel-contrib#2374
@jayconrod jayconrod mentioned this issue May 5, 2020
Merged
jayconrod pushed a commit that referenced this issue May 5, 2020
nogo: stop using go_tool_library (#2474)
8e6cfa5 
nogo binaries no longer depend on themselves. Since #2473, the nogo
rule uses a configuration transition to disable nogo for itself and
its dependencies.

This means there's no longer any need for go_tool_library rules for
analyzers and utility packages in org_golang_x_tools. So with this
change, tools_nogo depends on the regular go_library analyzers. The
documentation is updated not to mention go_tool_library anymore.

Additionally, this change replaces the go_tool_library targets in
org_golang_x_tools with aliases to the go_library targets. So nogo
targets that depends on the old symbols should work.

Fixes #2374
This was referenced May 8, 2020
Closed
Merged
@jayconrod jayconrod reopened this May 8, 2020
jayconrod pushed a commit that referenced this issue May 8, 2020
Revert changes migrating nogo to configuration transitions (#2481)
c0696e4 
This rolls back #2473 and #2474 due to #2479, which is caused by bazelbuild/bazel#11291. There doesn't seem to be a way to work around that, and I don't want to hold the release back any longer.

Reopens #2374
Reopens #2470
@jayconrod jayconrod removed this from the v0.23 milestone May 12, 2020
@bartle-stripe
Copy link
Contributor

ooc are there still plans to address this?

@jayconrod
Copy link
Contributor Author

Unfortunately, this is blocked by bazelbuild/bazel#11291.

@jayconrod jayconrod mentioned this issue Jul 8, 2020
Closed
@jayconrod jayconrod mentioned this issue Jul 15, 2020
Closed
@jayconrod jayconrod mentioned this issue Dec 16, 2020
Closed
@tux21b
Copy link

tux21b commented Apr 25, 2021

The upstream bug that has blocked this issue seems to be resolved now: bazelbuild/bazel#11291 (comment)

@thomas-wk thomas-wk mentioned this issue Jul 13, 2021
Merged
robfig pushed a commit to robfig/bazel-gazelle that referenced this issue Oct 6, 2021
language/go: stop generating go_tool_library rules for x/tools
1a9fb0f 
bazel-contrib/rules_go#2374 has been fixed, so there is no more need for it.
@robfig robfig mentioned this issue Oct 6, 2021
Merged
robfig pushed a commit to bazel-contrib/bazel-gazelle that referenced this issue Oct 6, 2021
language/go: stop generating go_tool_library rules for x/tools (#1110)
ce6d561 
bazel-contrib/rules_go#2374 has been fixed, so there is no more need for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement go nogo
Projects
None yet
Milestone
No milestone
4 participants
@achew22 @tux21b @jayconrod @bartle-stripe