use carved out module for x/tools/go/vcs #3671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
approved these changes
Aug 25, 2023
Yes, I agree with you. TiDB use this package in some linters. we will upgrade rules_go with upgrading all linters to the latest one. |
fmeum
reviewed
Aug 25, 2023
This part of golang.org/x/tools was removed from tools. The vcs code is still available in a separate module with a version marked as "deprecated". Let's use it for now.
|
There are a few references in tests/integration/popular_repos/... that were missed by this PR. But I will attempt to fix it when upgrade x/tools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of #3654 that was carved out to make it smaller and easier to understand.
The vcs part of golang.org/x/tools was removed from tools. The vcs code is still available in a separate module with a version marked as "deprecated". Let's use it for now.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
You can now upgrade golang.org/x/tools and rules_go will no longer try to use the vcs package from that module.
Note however, that updating golang.org/x/tools still triggers #3640.
To fix this, we need to update
golang.org/x/toolsin rules_go and use the new function signature (as shown in d09bc19).Other notes for review
We should probably vendor this code in the long term.