Make it easier to parse rules_go's .bzl files with Go Starlark #4140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though Bazel itself permits it, the Go Starlark interpreter does not. I think the Go Starlark interpreter is correct here, because plain Python also doesn't permit it.
|
Dear lord. Bazel itself doesn't support \u, even though it was added to Starlark three years ago: Let me remove the commit that was converting \x to \u for now. |
EdSchouten
force-pushed
the
eschouten/starlark-conformance
branch
from
ca51b01
to
7d3b73d
Compare
fmeum
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
I'm doing some experiments, where I'm trying to parse rules_go's source code with Go Starlark so that I can analyze it. In the process I've noticed that there are some small constructs that Go Starlark doesn't seem to like. In both those cases It looks like Go Starlark works as intended.
Which issues(s) does this PR fix?
n/a
Other notes for review