Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gazelle: Add support for rules_jvm_external v2 lockfile #127

Merged
merged 1 commit into from
Jan 30, 2023
Merged

gazelle: Add support for rules_jvm_external v2 lockfile #127

merged 1 commit into from
Jan 30, 2023

Conversation

stevebarrau
Copy link
Collaborator

Add support for the v2 lockfile format introduced in bazel-contrib/rules_jvm_external#822

CC @shs96c

illicitonion
illicitonion approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

shs96c
shs96c approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making it work with both lock file versions

@shs96c shs96c merged commit 37ff261 into bazel-contrib:main Jan 30, 2023
@stevebarrau stevebarrau deleted the gazelle-add-support-for-v2-lockfile branch January 30, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

@shs96c shs96c shs96c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevebarrau @shs96c @illicitonion