Skip to content

Commit

Permalink
Remove 'sp' from MAVEN_PRE_RELEASE_QUALIFIERS for outdated (#840)
Browse files Browse the repository at this point in the history
  • Loading branch information
cheister authored Jan 20, 2023
1 parent 0b272fd commit 5d266dd
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion private/rules/v1_lock_file.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ def _is_valid_lock_file(lock_file_contents):
# the build files.
return True


def _get_input_artifacts_hash(lock_file_contents):
dep_tree = lock_file_contents.get("dependency_tree", {})
return dep_tree.get("__INPUT_ARTIFACTS_HASH")
Expand Down
2 changes: 1 addition & 1 deletion private/tools/java/rules/jvm/external/maven/Outdated.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public class Outdated {
// https://github.com/apache/maven/blob/master/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java#L307
// and unfortunately ComparableVerison does not expose this in any public methods.
private static final List<String> MAVEN_PRE_RELEASE_QUALIFIERS =
Arrays.asList("alpha", "beta", "milestone", "cr", "rc", "snapshot", "sp");
Arrays.asList("alpha", "beta", "milestone", "cr", "rc", "snapshot");

public static class ArtifactReleaseInfo {
public String releaseVersion;
Expand Down

0 comments on commit 5d266dd

Please sign in to comment.