Improve repinning performance by not recomputing cache path for every artifact #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalestraPatrick
requested review from
jin,
Wyverald,
shs96c and
cheister
as code owners
jin
approved these changes
Apr 23, 2024
|
@jin any clue if there is a new release of rules_jvm_external in the plans for any time soon? We'd love to not have to add this as a patch on top of RJE in our workspace (I work with @BalestraPatrick ) |
|
Yeah we can cut 6.1 pretty soon. @shs96c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently investigated the performance of
rules_jvm_externalbecause runningREPIN=1 bazel run @unpinned_maven//:pinwas taking about 140s in our project. With this patch, it now takes about 20s.The bottleneck seemed to be
get_coursier_cache_or_defaultwhich was being invoked for every single artifact in a loop. Our repos have more ~1k artifacts, so this was a substantial amount of work.