New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: provide our own remove_prefix implementation #790

Merged

jin merged 1 commit into bazel-contrib:master from richardstephens:removeprefix-bazel-4

Nov 17, 2022

Contributor

richardstephens commented Nov 16, 2022

.removeprefix was only added to starlark on bazel 5, so this fails on bazel 4.


          fix: provide our own remove_prefix implementation

7b91330

`.removeprefix` was only added to starlark on bazel 5, so this fails on
bazel 4.

richardstephens requested a review from cheister as a code owner

November 16, 2022 15:40

jin approved these changes

View reviewed changes

Collaborator

jin left a comment

We do have support for Bazel 4+ so this looks reasonable to me.

jin merged commit 31792b7 into bazel-contrib:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet