Normalize path returned by get_coursier_cache_or_default in _relativize_and_symlink_file_in_coursier_cache

[anthonyjpratti]

Fixes #824.

Ideally, this would use paths.normalize in skylib, but that would require changes to how rules_jvm_external setups up dependencies.

[shs96c]

FYI, skylib is pulled in as a dependency via the repositories.bzl file. It's safe to rely on it. Would you prefer to use that?

[anthonyjpratti]

FYI, skylib is pulled in as a dependency via the repositories.bzl file. It's safe to rely on it. Would you prefer to use that?

So that was my first attempt, but I ran into the following issue. In rules_jvm_external_deps func, there is a bazel_skylib http archive and a maven_install; since maven_install relies on coursier.bzl and bazel_skylib isn't defined until rules_jvm_external_setup is invoked, skylib fails to be loaded in coursier.bzl. Since rules_jvm_external_deps and rules_jvm_external_setup are part of the public api for rules_jvm_external rules, I didn't want to modify that.

I'm open to recommendations on how to import skylib without breaking backwards compatibility. If there aren't concerns about backwards compatibility, then I do have a path forward for relying on skylib, but that's y'alls call.

[shs96c]

How frustrating! Well then, this will be excellent :) Thank you for the patch, and the explanation!

[shs96c]

LGTM

[anthonyjpratti]

How frustrating! Well then, this will be excellent :) Thank you for the patch, and the explanation!

I found it to be a great learning experience! I earnestly love when things break in ways I don't expect! :)