Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kotlin_stdlib to kt_jvm_export deploy_env. #884

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

sacsar
Copy link
Contributor

@sacsar sacsar commented Mar 27, 2023

Update kt_jvm_export to add the kotlint standard library to the deploy env so that it is not pulled in by maven_export.

I got the debug message telling me to update the lock file, so I did.

This covers part of #855 -- I haven't handled Scala here because there is not an existing dependency on rules_scala (and it does not currently support bzlmod).

Update `kt_jvm_export` to add the kotlint standard library to the deploy
env so that it is not pulled in by maven_export.
@sacsar sacsar requested a review from cheister as a code owner March 27, 2023 15:48
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revery the change to the v1 lock file: we left it in the old format so that we could continue to check whether any changes we make will break existing users who haven't updated their lock files.

Other than that, this looks good.

@sacsar sacsar requested review from shs96c and removed request for cheister March 29, 2023 21:08
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry about what we'll do if the stdlib isn't available, but we'll cross the bridge when someone files a bug report, since I think this is the way that rules_kotlin sets things up for everyone.

@shs96c shs96c merged commit 773111c into bazel-contrib:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants