Support so/dylib/dll packaging types #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbarsky
requested review from
jin,
Wyverald,
shs96c and
cheister
as code owners
dzbarsky
changed the title
dzbarsky
commented
Sep 15, 2023
private/dependency_tree_parser.bzl
Outdated
| name = "{dylib}_extension", | ||
| srcs = ["@{repository}//file"], | ||
| outs = ["{dylib}"], | ||
| cmd = "cp $< $@", |
There was a problem hiding this comment.
these copy rules exist to bring the artifacts into the @maven// top-level, which lets the user have a single java.library.path flag
|
@dzbarsky, my apologies for how long it's taking me to review this PR: I've traveled and have some work commitments, but I will get to this as soon as possible. |
No worries, this is not long at all compared to other projects I've contributed to in the past :) Thanks for the update! |
|
@shs96c Any idea when you'll have a chance to look at this one? |
shs96c
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be a bit nicer to set up the data dependencies in the generated rules, but I wasn't able to get it working when trying a combination of cc_import, java_library, etc. The downside of doing that is we wouldn't be able to use
selectto depend on just the platform-specific jar that we want.If anyone has ideas how to do better, let me know!