fix(builtin): js_library: propagate all default_runfiles (#3183)

Fixes #3182

internal/js_library/js_library.bzl

@@ -226,15 +226,25 @@ def _impl(ctx):
             if DefaultInfo in dep:
                 files_depsets.append(dep[DefaultInfo].files)
 
+    runfiles = ctx.runfiles(
+        files = all_files,
+        transitive_files = depset(
+            transitive = files_depsets + typings_depsets,
+        ),
+    )
+    deps_runfiles = [d[DefaultInfo].default_runfiles for d in ctx.attr.deps]
+
+    # Perf optimization available in newer Bazel releases
+    if "merge_all" in dir(runfiles):
+        runfiles = runfiles.merge_all(deps_runfiles)
+    else:
+        for d in deps_runfiles:
+            runfiles = runfiles.merge(d)
+
     providers = [
         DefaultInfo(
             files = depset(transitive = files_depsets),
-            runfiles = ctx.runfiles(
-                files = all_files,
-                transitive_files = depset(
-                    transitive = files_depsets + typings_depsets,
-                ),
-            ),
+            runfiles = runfiles,
         ),
         AmdNamesInfo(names = ctx.attr.amd_names),
         js_ecma_script_module_info(

internal/js_library/test/transitive/BUILD.bazel

@@ -1,13 +1,30 @@
 load("//:index.bzl", "js_library")
 load(":transitive_declarations_test.bzl", "transitive_declarations_test_suite")
+load("//packages/typescript:index.bzl", "ts_project")
+
+js_library(
+    name = "c",
+    srcs = [
+        "c.d.ts",
+        "c.txt",
+    ],
+)
+
+ts_project(
+    name = "b",
+    srcs = ["b.ts"],
+    tsconfig = {},
+    deps = ["c"],
+)
 
 js_library(
     name = "a",
     srcs = ["a.d.ts"],
+    deps = ["b"],
 )
 
 js_library(
-    name = "b",
+    name = "terminal",
     deps = ["a"],
 )
 

internal/js_library/test/transitive/b.ts

@@ -0,0 +1 @@
+const a = 1;

internal/js_library/test/transitive/c.d.ts

@@ -0,0 +1 @@
+export declare const c: string;

internal/js_library/test/transitive/c.txt

@@ -0,0 +1 @@
+this is a

internal/js_library/test/transitive/transitive_declarations_test.bzl

@@ -5,15 +5,23 @@ load("@rules_nodejs//nodejs:providers.bzl", "DeclarationInfo")
 
 def _impl(ctx):
     env = unittest.begin(ctx)
+
     decls = []
     for decl in ctx.attr.lib[DeclarationInfo].declarations.to_list():
         decls.append(decl.basename)
-    asserts.equals(env, ctx.attr.declarations, decls)
+    asserts.equals(env, ctx.attr.expected_declarations, sorted(decls))
+
+    runfiles = []
+    for r in ctx.attr.lib[DefaultInfo].default_runfiles.files.to_list():
+        runfiles.append(r.basename)
+    asserts.equals(env, ctx.attr.expected_runfiles, sorted(runfiles))
+
     return unittest.end(env)
 
 transitive_declarations_test = unittest.make(_impl, attrs = {
-    "declarations": attr.string_list(default = ["a.d.ts"]),
-    "lib": attr.label(default = ":b"),
+    "expected_declarations": attr.string_list(default = ["a.d.ts"]),
+    "lib": attr.label(default = ":terminal"),
+    "expected_runfiles": attr.string_list(default = ["a.d.ts", "b.js", "c.d.ts", "c.txt"]),
 })
 
 def transitive_declarations_test_suite():