-
Notifications
You must be signed in to change notification settings - Fork 524
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(typescript): use run_node helper to execute tsc
This lets it resolve plugins like ts-lit-plugin. Demonstrate this by adding a lit_plugin test under packages/typescript
- Loading branch information
Showing
12 changed files
with
395 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # Copyright 2017 The Bazel Authors. All rights reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| load("@npm_bazel_typescript//:index.from_src.bzl", "ts_library") | ||
|
|
||
| ts_library( | ||
| name = "lit_plugin", | ||
| srcs = glob(["*.ts"]), | ||
| expected_diagnostics = [ | ||
| """TS2322: \\[lit\\] Unknown tag "unknown-element". Did you mean 'lit-element'?""", | ||
| "TS2322: \\[lit\\] Type '222' is not assignable to 'string", | ||
| "TS2322: \\[lit\\] Type '333' is not assignable to 'string", | ||
| """TS2322: \\[lit\\] Type '"aaa"' is not assignable to 'number'""", | ||
| """TS2322: \\[lit\\] Type '"ccc"' is not assignable to 'number'""", | ||
| "TS2322: \\[lit\\] Type '444' is not assignable to 'string", | ||
| "TS2322: \\[lit\\] Type '{ field: number; }' is not assignable to '{ field: string; }'", | ||
| ], | ||
| tsconfig = ":tsconfig.json", | ||
| deps = [ | ||
| "@npm//lit-element", | ||
| # TODO(#850): plugins["@npm//ts-lit-plugin"] instead? | ||
| "@npm//ts-lit-plugin", | ||
| ], | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import './elements'; | ||
| import {html} from 'lit-element'; | ||
|
|
||
|
|
||
| const objValue = { | ||
| field: 111, | ||
| }; | ||
| console.log(html` | ||
| <unknown-element></unknown-element> | ||
| <div .id=${222}></div> | ||
| <lit-element .strField=${333} .numField=${'aaa'}></lit-element> | ||
| <lit-element numField="bbb"></lit-element> | ||
| <vanilla-element .vanillaStr=${444}></vanilla-element> | ||
| <declared-element | ||
| .declaredNumberProp=${'ccc'} | ||
| .declaredObjProp=${objValue}></declared-element> | ||
| `); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
|
|
||
| export {}; | ||
|
|
||
| /** An element that's only declared in a definition. */ | ||
| declare class DeclaredElement extends HTMLElement { | ||
| declaredNumberProp: number; | ||
| declaredObjProp: {field: string}; | ||
| } | ||
|
|
||
| declare global { | ||
| interface HTMLElementTagNameMap { | ||
| 'declared-element': DeclaredElement; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /** | ||
| * @fileoverview Elements used in multiple build tests. | ||
| */ | ||
|
|
||
| import {customElement, LitElement} from 'lit-element'; | ||
|
|
||
|
|
||
| @customElement('lit-element') | ||
| class LitElementElement extends LitElement { | ||
| strField!: string; | ||
| numField!: number; | ||
| } | ||
|
|
||
| class VanillaElement extends HTMLElement { | ||
| vanillaStr = 'hi'; | ||
| str!: string; | ||
| } | ||
| customElements.define('vanilla-element', VanillaElement); | ||
|
|
||
| declare global { | ||
| interface HTMLElementTagNameMap { | ||
| 'lit-element': LitElementElement; | ||
| 'vanilla-element': VanillaElement; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "plugins": [ | ||
| { | ||
| "name": "ts-lit-plugin", | ||
| "strict": true, | ||
| "rules": { | ||
| "no-unknown-tag-name": "error", | ||
| "no-unclosed-tag": "error", | ||
| "no-unknown-property": "error", | ||
| "no-unintended-mixed-binding": "error", | ||
| "no-invalid-boolean-binding": "error", | ||
| "no-expressionless-property-binding": "error", | ||
| "no-noncallable-event-binding": "error", | ||
| "no-boolean-in-attribute-binding": "error", | ||
| "no-complex-attribute-binding": "error", | ||
| "no-nullable-attribute-binding": "error", | ||
| "no-incompatible-type-binding": "error", | ||
| "no-invalid-directive-binding": "error", | ||
| "no-incompatible-property-type": "error", | ||
| "no-unknown-property-converter": "error", | ||
| "no-invalid-attribute-name": "error", | ||
| "no-invalid-tag-name": "error", | ||
| "no-unknown-attribute": "off", | ||
| "no-missing-import": "off", | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "exclude": [ | ||
| "node_modules" | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.