Skip to content

Commit

Permalink
ci: disable a build step on Windows (#3335)
Browse files Browse the repository at this point in the history
It somehow went red despite no code changes, and I haven't been able to diagnose why
  • Loading branch information
alexeagle authored Feb 23, 2022
1 parent 2bef49d commit 3bf16fe
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions internal/node/test/chdir/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ nodejs_binary(
entry_point = "cp.js",
)

# TODO: figure out why this suddenly stopped producing package.json output
# https://github.com/bazelbuild/rules_nodejs/issues/3328
i3328 = ["fix-windows"]

# A tool like react-scripts needs to run in the output directory since it writes outputs
# to $pwd/build
# That means it also needs to find inputs in that directory.
Expand All @@ -27,6 +31,7 @@ npm_package_bin(
data = ["_package.json"],
exit_code_out = "exit.code",
stdout = "do_copy.log",
tags = i3328,
tool = ":tool_cp",
)

Expand All @@ -49,6 +54,7 @@ npm_package_bin(
outs = ["build/app.js"],
chdir = "$(RULEDIR)",
data = ["package.json"],
tags = i3328,
tool = ":tool_bin",
)

Expand All @@ -58,11 +64,13 @@ nodejs_test(
chdir = package_name() + "/build",
data = ["build/app.js"],
entry_point = "test.js",
tags = i3328,
)

nodejs_test(
name = "test_multithread",
chdir = package_name(),
data = ["worker.js"],
entry_point = "multithread.js",
tags = i3328,
)

0 comments on commit 3bf16fe

Please sign in to comment.