chore(builtin): add missing testing for browserify vendored binary

internal/npm_install/test/BUILD.bazel

@@ -1,4 +1,5 @@
 load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test", "nodejs_binary")
+load("@build_bazel_rules_nodejs//internal/npm_install:npm_umd_bundle.bzl", "npm_umd_bundle")
 
 filegroup(
     name = "goldens",
@@ -7,7 +8,7 @@ filegroup(
 
 jasmine_node_test(
     name = "test",
-    srcs = glob(["*.spec.js"]),
+    srcs = ["generate_build_file.spec.js"],
     data = [
         ":check.js",
         ":goldens",
@@ -31,3 +32,20 @@ nodejs_binary(
     entry_point = ":update_golden.js",
     install_source_map_support = False,
 )
+
+npm_umd_bundle(
+    name = "some-bundle",
+    package_name = "some-package-name",
+    entry_point = "@npm//:node_modules/minimist/index.js",
+    package = "@npm//minimist",
+)
+
+jasmine_node_test(
+    name = "browserify_test",
+    srcs = ["browserify.spec.js"],
+    data = [
+        ":some-package-name.umd.js",
+        "//internal/npm_install:browserify-wrapped",
+        "@npm//jasmine",
+    ],
+)

internal/npm_install/test/browserify.spec.js

@@ -0,0 +1,16 @@
+const fs = require('fs');
+const mainFile = 'build_bazel_rules_nodejs/third_party/github.com/browserify/browserify/index.min.js';
+
+describe('our bundled, vendored browserify binary', () => {
+    it('should preserve licenses', () => {
+        const idxFile = fs.readFileSync(require.resolve(mainFile), {encoding: 'utf-8'});
+        expect(idxFile).toContain('Copyright Joyent');
+        expect(idxFile).toMatch(/Copyright \d+ Mozilla/);
+        expect(idxFile).toContain('Feross Aboukhadijeh');
+    });
+    it('should work', () => {
+        const minimistUmd = require('build_bazel_rules_nodejs/internal/npm_install/test/some-package-name.umd.js');
+        const result = minimistUmd('h');
+        expect(result._[0]).toBe('h');
+    });
+});

scripts/vendor_browserify.sh

@@ -12,5 +12,5 @@ echo "Copy LICENSE"
 cp -f ./node_modules/browserify/LICENSE ./third_party/github.com/browserify/browserify
 
 echo "Minifying browserify with tserver"
-./node_modules/.bin/terser --compress --mangle --comments '/(^!|@license|@preserve)/' -- third_party/github.com/browserify/browserify/index.js > third_party/github.com/browserify/browserify/index.min.js
+./node_modules/.bin/terser --compress --mangle --comments '/(^!|@license|@preserve|Copyright)/' -- third_party/github.com/browserify/browserify/index.js > third_party/github.com/browserify/browserify/index.min.js