Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit cross-platform RBE mechanics #1415

Closed
gregmagolan opened this issue Dec 4, 2019 · 1 comment
Closed

Revisit cross-platform RBE mechanics #1415

gregmagolan opened this issue Dec 4, 2019 · 1 comment
Labels
Can Close? We will close this in 30 days if there is no further activity

Comments

@gregmagolan
Copy link
Collaborator

gregmagolan commented Dec 4, 2019 •
edited
Loading

Its hacky right now. It looks like we will need fixes in Bazel to get it to work properly so this is a place to add context and discuss.

I will add more details here about the hacky way cross-platform RBE currently works with nodejs_binary & ts_devserver and how it should ideally work.

Underlying issue described here:
nodejs_binary incorrectly chooses the target platform with RBE #1305

Hacky fixes introduced here:
fix: fix nodejs_binary cross-platform RBE issue #1305
fix(typescript): fix for cross platform ts_devserver issue #1409
gregmagolan added a commit that referenced this issue Dec 4, 2019
@gregmagolan
fix(typescript): fix for cross platform ts_devserver issue #1409 (#1413)
172caff 
This change allows a ts_devserver target to be build with cross platform RBE (host platform is osx or Windows & execution platform is linux) and still run on the host platform.

With cross-platform RBE for OSX & Windows ctx.executable.devserver will be linux as --cpu and --host_cpu must be overridden to k8. However, we still want to be able to run the devserver on the host machine so we need to include the host devserver binary, which is ctx.executable.devserver_host, in the runfiles. For non-RBE and for RBE with a linux host, ctx.executable.devserver & ctx.executable.devserver_host will be the same binary.

Issue for re-visiting this in the future is: Revisit cross-platform RBE mechanics #1415
@gregmagolan gregmagolan mentioned this issue Dec 4, 2019
Merged
12 tasks
@evahowe evahowe added the Can Close? We will close this in 30 days if there is no further activity label Jun 17, 2020
@github-actions
Copy link

This issue was automatically closed because it went two weeks without a reply since it was labeled "Can Close?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Can Close? We will close this in 30 days if there is no further activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregmagolan @evahowe